Allow PosteriorTransform API to optionally accept features X #3117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D89930506. |
…torch#3117) Summary: This change updates the `PosteriorTransform` API to optionally accept features `X` in addition to the values `Y` (for `evaluate()`) or posterior (for `forward()`). This aligns `PosteriorTransform` with `MCAcquisitionObjective`, which already accepts `X` to enable input-dependent objectives. The change enables use cases where posterior transformations need to depend on the input features explicitly. Updates all posterior transform classes and callsites to accept / pass in X along with the posterior Resolves meta-pytorch#1548 Differential Revision: D89930506
saitcakmak
force-pushed
the
export-D89930506
branch
from
e86512c to
8d8ee9a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3117 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 219 219
Lines 21253 21254 +1
=======================================
+ Hits 21251 21252 +1
Misses 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change updates the
PosteriorTransformAPI to optionally accept featuresXin addition to the valuesY(forevaluate()) or posterior (forforward()).This aligns
PosteriorTransformwithMCAcquisitionObjective, which already acceptsXto enable input-dependent objectives. The change enables use cases where posterior transformations need to depend on the input features explicitly.Updates all posterior transform classes and callsites to accept / pass in X along with the posterior
Resolves #1548
Differential Revision: D89930506