Skip to content

Add stateful dl import to smoke test#1299

Open
gokulavasan wants to merge 4 commits intomainfrom
more-smoke-test
Open

Add stateful dl import to smoke test#1299
gokulavasan wants to merge 4 commits intomainfrom
more-smoke-test

Conversation

@gokulavasan
Copy link
Copy Markdown
Contributor

title

Fixes #{issue number}

Changes

@gokulavasan gokulavasan requested a review from atalman July 25, 2024 22:35
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2024
if options.s3:
s3_test()

if torchdata.__version__ >= "0.8.0":
Copy link
Copy Markdown
Contributor

@atalman atalman Jul 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please throw exception here if torchdata.__version__ != 0.8.0
We would need to route it later via input parameter. However this can be a followup PR

Copy link
Copy Markdown
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address comment and we are good to merge

@gokulavasan gokulavasan changed the base branch from main to release/0.8 July 26, 2024 05:33
@gokulavasan gokulavasan changed the base branch from release/0.8 to main July 26, 2024 05:34
@gokulavasan
Copy link
Copy Markdown
Contributor Author

@atalman Is that change what you had in mind? Can you also confirm if it is fine to land this in main branch (with the check being about 0.8.0) and the cherry pick this to release/0.8 branch?

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jul 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1299

Note: Links to docs will display an error until the docs builds have been completed.

❌ 14 New Failures

As of commit f4d0986 with merge base de5791b (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@meta-cla
Copy link
Copy Markdown

meta-cla bot commented Mar 21, 2026

Hi @gokulavasan!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants