Conversation
test/smoke_test/smoke_test.py
Outdated
| if options.s3: | ||
| s3_test() | ||
|
|
||
| if torchdata.__version__ >= "0.8.0": |
There was a problem hiding this comment.
Please throw exception here if torchdata.__version__ != 0.8.0
We would need to route it later via input parameter. However this can be a followup PR
atalman
left a comment
There was a problem hiding this comment.
please address comment and we are good to merge
|
@atalman Is that change what you had in mind? Can you also confirm if it is fine to land this in main branch (with the check being about 0.8.0) and the cherry pick this to release/0.8 branch? |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1299
Note: Links to docs will display an error until the docs builds have been completed. ❌ 14 New FailuresAs of commit f4d0986 with merge base de5791b ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
d185e39 to
322712c
Compare
|
Hi @gokulavasan! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
title
Fixes #{issue number}
Changes