Skip to content

Fix hang when batch_size=0 by validating input #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mihirmaru22 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix hang when batch_size=0 by validating input #1522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84ec105
Fix hang when batch_size=0 by validating input
Mihirmaru22 Jan 8, 2026
1724ea1
Format test_batch.py with ufmt
Mihirmaru22 Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions test/nodes/test_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import torch
from parameterized import parameterized
from torch.testing._internal.common_utils import TestCase
from torchdata.nodes import IterableWrapper
from torchdata.nodes.batch import Batcher, Unbatcher

from .utils import MockSource, run_test_save_load_state
Expand All @@ -28,6 +29,11 @@ def test_batcher(self) -> None:
self.assertEqual(results[i][j]["test_tensor"], torch.tensor([i * batch_size + j]))
self.assertEqual(results[i][j]["test_str"], f"str_{i * batch_size + j}")

def test_batcher_batch_size_zero_raises(self):
source = IterableWrapper(range(10))
with self.assertRaises(ValueError):
Batcher(source, batch_size=0)

def test_batcher_drop_last_false(self) -> None:
batch_size = 6
src = MockSource(num_samples=20)
Expand Down
2 changes: 2 additions & 0 deletions torchdata/nodes/batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ class Batcher(BaseNode[List[T]]):

def __init__(self, source: BaseNode[T], batch_size: int, drop_last: bool = True):
super().__init__()
if batch_size <= 0:
raise ValueError("batch_size must be a positive integer")
self.source = source
self.batch_size = batch_size
self.drop_last = drop_last
Expand Down