[WIP] Refactoring test cases and dependent files to be device agnostic instead of using cuda specific references #308
Conversation
Summary: Pull Request resolved: meta-pytorch#306 TorchFT CI is installing the latest `opentelemetry-sdk`, which caused breakages in some of the APIs in otel.py. This PR updates `otel.py` to use the correct APIs. This PR also fixes TorchFT lint (pyre check was failing). This should resolve the failing TorchFT CI failures: https://github.com/meta-pytorch/torchft/actions/runs/19983176027/job/57313269930 This is also causing downstream CI failures in in torchtitan: https://github.com/pytorch/torchtitan/actions/workflows/integration_test_8gpu_torchft.yaml Pull Request resolved: meta-pytorch#305 Reviewed By: tianyu-l Differential Revision: D89743414 Pulled By: H-Huang fbshipit-source-id: c066fe535b332ba94b918f5b684595c8de8b6740
…ce agnostic process group class
|
Hi @AnantGulati! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
2 participants
As discussed in RFC: #257
We aim to replace all cuda specific mentions with device agnostic use cases
This PR is dependent on PR: #307