Do not (re-)load swagger-schema.json from the Internet #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The id specifies the URL resolution scope for the $refs in the schema. When validating an object against the schema, scjsv tries to dereference that URL, which means requesting it from the Internet.
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done by unsetting the id field in
swagger-schema.json.At first I thought the right way to do this would be to use inline dereferencing. Now I'm thinking that ring-swagger would need inline dereferencing only accidentally - the real problem is that scjsv does not know that the URL of the schema is the same as its id.
There are two solutions: to remove the id (like in this PR) or to teach scjsv about the URL by creating a JsonLoadingFactory with this schema preloaded for the right URL.