feat: added button for global min/max toggle, fixes #74 #88
Conversation
index.html
Outdated
| @@ -33,6 +33,10 @@ | |||
| <img class="navimg" src="img/icons/file-earmark-arrow-down.svg"/> | |||
| Export | |||
| </button> | |||
| <label class="btn btn-outline-primary"> | |||
| <input type="checkbox" id='checkbox_min_max' checked=true v-on:click="toggleMinMaxButtonClicked"> min/avg/max | |||
There was a problem hiding this comment.
Since, avg is always shown with this button, we can remove it from the description text.
There was a problem hiding this comment.
The glue between the checkbox element and the JS code should probably be v-model or v-bind. I'm just not sure how this can deal gracefully with the intermediate state (see vuejs/vue#4094).
| getMetricDrawState (metricName) { | ||
| for (const metricBase in this.state.allMetrics) { | ||
| const metricArray = [] | ||
| if (this.state.allMetrics[metricBase].name === metricName) { |
There was a problem hiding this comment.
We really need a better way to get a metric by name other than looping through all metrics... But I guess this is a different refactoring issue.
|
The global toggle is very good already. However, we didn't really think about showing only min or mix without the other as we currently only have the min-to-max band. I think in the |
|
Oddly, the global toggle field is not vertically aligned with the other global buttons in my browser (both chromium and firefox). |
Fixed |
fixed |
is now 'only avg' while global is indeterminate
AndyBuchwald
force-pushed
the
fix-issue-74
branch
from
cdc5a44 to
76260d3
Compare
No description provided.