Fix logic bug in Count detection on right side

Copilot · meziantou · Copilot · commit 3bad1cb41437 · 2025-12-17T19:45:42.000Z
Co-authored-by: meziantou &lt;509220+meziantou@users.noreply.github.com&gt;
diff --git a/src/Meziantou.Analyzer.CodeFixers/Rules/UseAttributeIsDefinedFixer.cs b/src/Meziantou.Analyzer.CodeFixers/Rules/UseAttributeIsDefinedFixer.cs
@@ -75,11 +75,15 @@ private static async Task<Document> ReplaceWithAttributeIsDefined(Document docum
                 else
                 {
                     // Check for GetCustomAttributes().Count() comparisons
-                    var countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.LeftOperand, out var countIsOnLeft);
+                    var countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.LeftOperand, out var foundOnLeft);
+                    var countIsOnLeft = foundOnLeft;
                     if (countInvocation is null)
                     {
-                        countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.RightOperand, out var countIsOnRight);
-                        countIsOnLeft = !countIsOnRight; // If found on right, Count is not on left
+                        countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.RightOperand, out var foundOnRight);
+                        if (foundOnRight)
+                        {
+                            countIsOnLeft = false; // Count is on right side
+                        }
                     }
 
                     if (countInvocation is not null)

Original file line number	Diff line number	Diff line change
`@@ -75,11 +75,15 @@ private static async Task<Document> ReplaceWithAttributeIsDefined(Document docum`
`75`	`75`	`else`
`76`	`76`	`{`
`77`	`77`	`// Check for GetCustomAttributes().Count() comparisons`
`78`		`- var countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.LeftOperand, out var countIsOnLeft);`
	`78`	`+ var countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.LeftOperand, out var foundOnLeft);`
	`79`	`+ var countIsOnLeft = foundOnLeft;`
`79`	`80`	`if (countInvocation is null)`
`80`	`81`	`{`
`81`		`- countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.RightOperand, out var countIsOnRight);`
`82`		`- countIsOnLeft = !countIsOnRight; // If found on right, Count is not on left`
	`82`	`+ countInvocation = GetGetCustomAttributesCountInvocation(binaryOperation.RightOperand, out var foundOnRight);`
	`83`	`+ if (foundOnRight)`
	`84`	`+ {`
	`85`	`+ countIsOnLeft = false; // Count is on right side`
	`86`	`+ }`
`83`	`87`	`}`
`84`	`88`
`85`	`89`	`if (countInvocation is not null)`