Skip to content

Allow symfony/process:^6 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 20, 2022
Merged

Conversation

snapshotpl
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Allow symfony/process v6

Signed-off-by: Witold Wasiczko <[email protected]>
@snapshotpl snapshotpl added the Enhancement New feature or request label Jan 3, 2022
@snapshotpl snapshotpl added this to the 2.5.0 milestone Jan 3, 2022
@Ocramius
Copy link
Member

Ocramius commented Jan 3, 2022

Looks like this is failing due to latest composer/composer? 🤔

@snapshotpl
Copy link
Member Author

No idea. Locally updated to newest composer and running on PHP 7.4.3 pass in 100%.

@Ocramius
Copy link
Member

Ocramius commented Jan 4, 2022

Yeah, potentially fixed by https://github.com/composer/composer/releases/tag/2.2.3

I wonder if we should upgrade our CI images regularly 🤔

@boesing
Copy link
Member

boesing commented Jan 4, 2022

I wonder if we should upgrade our CI images regularly 🤔

We've already talked about that regarding new PHP versions.
PHP is released on a monthly based, so we could schedule for monthly builds.
But this won't help us in this specific case, so we would end-up having manual builds for these cases where composer has released bugfixes we do need.

@Ocramius
Copy link
Member

Ocramius commented Jan 4, 2022

@boesing if we use COPY --from=composer:2.2.3, for example, then @dependabot could potentially pick up on that, and upgrade it regularly.

In this case, I really believe the bug is either with composer/composer or phpunit/phpunit

@snapshotpl
Copy link
Member Author

How to update composer here?

@Ocramius
Copy link
Member

Ocramius commented Jan 4, 2022

@boesing
Copy link
Member

boesing commented Jan 6, 2022

@boesing if we use COPY --from=composer:2.2.3, for example, then @dependabot could potentially pick up on that, and upgrade it regularly.

Really? dependabot is able to bump dockerfile? That would be awesome!

@Ocramius
Copy link
Member

Ocramius commented Jan 6, 2022

It does: using it regularly on customer projects that are docker-heavy 💪

Signed-off-by: Witold Wasiczko <[email protected]>
@Ocramius
Copy link
Member

Looks like some adjustments are needed for static analysis, but otherwise really promising 💪

Signed-off-by: Witold Wasiczko <[email protected]>
@Ocramius Ocramius merged commit bb6dc8e into mezzio:2.5.x Jan 20, 2022
@Ocramius
Copy link
Member

Thanks @snapshotpl!

@snapshotpl
Copy link
Member Author

Wait a minute, fixing some psalm issues now

@Ocramius Ocramius changed the title Allow symfony/process 6 Allow symfony/process:^6 Jan 20, 2022
@Ocramius
Copy link
Member

Too late :|

@Ocramius
Copy link
Member

Send me another patch, I'll factor it in the release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants