Jump on stopped event if same threadId is already marked as stopped #901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some debug adapters allow to resume execution using custom evaluate commands. This unfortunately by-passes some logic that puts the client into "running" state again. If the client then receives a stopped event it assumed it was already stopped and sent a continue request (unless `auto_continue_if_many_stopped` was disabled) This changes the condition to also jump if `stopped_thread_id == stopped.threadId` Closes #898 Co-authored-by: xac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some debug adapters allow to resume execution using custom evaluate
commands. This unfortunately by-passes some logic that puts the client
into "running" state again.
If the client then receives a stopped event it assumed it
was already stopped and sent a continue request (unless
auto_continue_if_many_stoppedwas disabled)This changes the condition to also jump if
stopped_thread_id == stopped.threadIdCloses #898
Co-authored-by: xac [email protected]