remove REPL history clear when starting a new session #942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
This would also stop clearing the output, which I very much want to keep. I don't mind not clearing the history, but then it would probably need to become a ringbuffer to avoid the memory usage from growing indefinitely. |
Contributor
Author
|
I have made changes according to your review. I have added a maximum REPL history size, with a hardcoded max size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently starting a new session clears the REPL history. I see no reason why this is required, and actually I have found quite common the need to reuse REPL command between sessions.
Other IDEs (e.g. vscode) also keep history between sessions.