Skip to content

Merge DEV_NPM_DEPENDENCIES and PROD_NPM_DEPENDENCIES #629

Closed
@mgechev

Description

@mgechev

It is confusing and redundant to have two different arrays of injectable dependencies.

The biggest current benefits of these two configuration options are:

  • Faster loading of the development build (we're able to inject bundles instead of load the individual dependencies one by one, what the prod build does).
  • We're able to use pre-minified version of some of the dependencies for the production build. This can eventually save some bandwidth if the files are minified in a special way (using Closure Compiler or uglifyjs wth mangling).

Generally only a single array of dependencies will be enough, and the difference in the treatment of the files could come from the configuration of the SystemJS builder that we use.

For some advanced builds it could be better to preserve both configuration options. My suggestion is to keep PROD_DEPENDENCIES with value null by default. If the user of the seed needs more custom behavior she can define PROD_DEPENDENCIES array and get the current behavior.

// cc @ludohenin @d3viant0ne

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions