-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Merge DEV_NPM_DEPENDENCIES and PROD_NPM_DEPENDENCIES #629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I personally prefer having both configurations. That said, defaulting to "easy mode" and documenting how to use Quick on page doc on adding jquery, bootstrap & perhaps one popular package in an advanced configuration would cover most of the questions in the closed issues. |
Another |
@ludohenin getters seems like a good idea. @d3viant0ne I like the two modes. In such case we can:
This way we get:
|
It is confusing and redundant to have two different arrays of injectable dependencies.
The biggest current benefits of these two configuration options are:
Generally only a single array of dependencies will be enough, and the difference in the treatment of the files could come from the configuration of the SystemJS builder that we use.
For some advanced builds it could be better to preserve both configuration options. My suggestion is to keep
PROD_DEPENDENCIES
with valuenull
by default. If the user of the seed needs more custom behavior she can definePROD_DEPENDENCIES
array and get the current behavior.// cc @ludohenin @d3viant0ne
The text was updated successfully, but these errors were encountered: