-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feature-suggestion: simplify scss stylesheet implementation #895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @hank-ehly, stating my personal opinion, i would like to see this included in the seed. I know there have been arguments against it (referecing #746 as base of the discussion), but i think providing sass support which can be toggled by configuration would be a good compromise. Greetings Dope |
Sounds good to me. Not sure if it is worth it to be part of the global project configuration or plugin specific config which was recently implemented by @brian428 here 9a86bf5. I don't mind merging it since it seems that Sass is very desired feature. @d3viant0ne and @ludohenin what are your thoughts? |
@mgechev |
Awesome, looking forward to see it! |
@hank-ehly Don't know if this will help but in version |
I'm using http://cssnext.io with |
@htdt - I normally use pre/postcss for scss functionality but there are and always will be people that want or need to use a preprocessor for their styles. Personally I think the ability to simply define your style sheets implementation of choice without having to jump through a bunch of hoops is a solid feature. |
I have rebased my commits onto the current master branch and submitted a pull request for your review (#952) Just as @d3viant0ne mentioned, this allows users to define their stylesheet preference without having to manually edit any seed files.
Thank you for your consideration Hank |
Thank you very much @hank-ehly for the PR :) |
IMPORTANT: This repository's issues are reserved for feature requests and bug reports. Do not submit support requests here.
Steps to reproduce and a minimal demo of the problem
What steps should we try in your demo to see the problem?
Current behavior
Users are able to enable sass support by following the instructions on the Wiki page, or by referencing the angular2-seed-sass fork.
Expected/desired behavior
Allow seed users to enable sass support by specifying a command-line / project.config variable.
Other information
In issue #746 , @ludohenin and @d3viant0ne mentioned the benefit of providing an easier way of implementing scss stylesheets.
I have created a rough example of how this could be done. I understand this issue may be low-priority, but I hope you can consider my contribution.
The text was updated successfully, but these errors were encountered: