Skip to content

feature-suggestion: simplify scss stylesheet implementation #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hankehly opened this issue May 18, 2016 · 9 comments
Closed

feature-suggestion: simplify scss stylesheet implementation #895

hankehly opened this issue May 18, 2016 · 9 comments
Labels

Comments

@hankehly
Copy link
Contributor

IMPORTANT: This repository's issues are reserved for feature requests and bug reports. Do not submit support requests here.

Steps to reproduce and a minimal demo of the problem

What steps should we try in your demo to see the problem?

Current behavior
Users are able to enable sass support by following the instructions on the Wiki page, or by referencing the angular2-seed-sass fork.

Expected/desired behavior
Allow seed users to enable sass support by specifying a command-line / project.config variable.

Other information
In issue #746 , @ludohenin and @d3viant0ne mentioned the benefit of providing an easier way of implementing scss stylesheets.

I have created a rough example of how this could be done. I understand this issue may be low-priority, but I hope you can consider my contribution.

@TheDonDope
Copy link
Contributor

Hi @hank-ehly,

stating my personal opinion, i would like to see this included in the seed. I know there have been arguments against it (referecing #746 as base of the discussion), but i think providing sass support which can be toggled by configuration would be a good compromise.

Greetings

Dope

@mgechev
Copy link
Owner

mgechev commented May 29, 2016

Sounds good to me. Not sure if it is worth it to be part of the global project configuration or plugin specific config which was recently implemented by @brian428 here 9a86bf5.

I don't mind merging it since it seems that Sass is very desired feature. @d3viant0ne and @ludohenin what are your thoughts?

@hankehly
Copy link
Contributor Author

@mgechev
Thank you for your feedback.
I will prepare a refactored & up-to-date version of the above fork for your review by June 1st.

@mgechev
Copy link
Owner

mgechev commented May 29, 2016

Awesome, looking forward to see it!

@ludohenin
Copy link
Collaborator

@hank-ehly Don't know if this will help but in version 2.0.0 of gulp-inline-ng2-template I've added async support for processor functions (template and styles) and customFilePath ... just to let you know.

@htdt
Copy link

htdt commented May 30, 2016

I'm using http://cssnext.io with postcss-import as an alternative to sass. It works as a polyfill, neat and compact in this seed. There was an issue with build.js.test, but async support in gulp-inline-ng2-template just has solved it. If somebody is interested, I can share the tasks.

@joshwiens
Copy link
Contributor

@htdt - I normally use pre/postcss for scss functionality but there are and always will be people that want or need to use a preprocessor for their styles.

Personally I think the ability to simply define your style sheets implementation of choice without having to jump through a bunch of hoops is a solid feature.

@hankehly
Copy link
Contributor Author

hankehly commented Jun 1, 2016

@mgechev,

I have rebased my commits onto the current master branch and submitted a pull request for your review (#952)

Just as @d3viant0ne mentioned, this allows users to define their stylesheet preference without having to manually edit any seed files.

  • To begin using scss, specify the flag: npm start -- --scss
    • If everyone would rather enable scss-processing without modifying the global project configuration, please let me know and I will find a different solution.
  • References to stylesheetUrls from .ts components should use the .css format, not .scss

Thank you for your consideration

Hank

mgechev added a commit that referenced this issue Jun 2, 2016
@TheDonDope
Copy link
Contributor

Thank you very much @hank-ehly for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants