Skip to content

Specify ENABLE_SCSS setting via environment variable #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 9, 2016
Merged

Specify ENABLE_SCSS setting via environment variable #1603

merged 4 commits into from
Nov 9, 2016

Conversation

hankehly
Copy link
Contributor

@hankehly hankehly commented Nov 6, 2016

Some npm run-scripts contain multiple gulp comman-
ds (ex. e2e.ci). Multiple gulp commands may refer-
ence the ENABLE_SCSS setting; however, '--scss' is
only appended to the final command:

gulp ... && gulp ... && gulp ... "--scss"

This results in a build error.

To provide each command in an npm run-script the
correct ENABLE_SCSS setting, set the ENABLE_SCSS
setting using an environment variable rather than
a command-line argument.

BREAKING CHANGES

  1. The '--scss' no longer has any effect
  2. To enable SASS support via the command line,
    one must prefix their run-script command with
    ENABLE_SCSS=1 or ENABLE_SCSS=true.

hankehly and others added 2 commits November 6, 2016 12:03
@hankehly
Allow ENABLE_SCSS flag to be set via ENV variable
68dbfa0 
Some npm run-scripts contain multiple gulp comman-
ds (ex. e2e.ci). Multiple gulp commands may refer-
ence the ENABLE_SCSS setting; however, '--scss' is
only appended to the final command:

    gulp ... && gulp ... && gulp ... "--scss"

This results in a build error.

To provide each command in an npm run-script the
correct ENABLE_SCSS setting, set the ENABLE_SCSS
setting using an environment variable rather than
a command-line argument.

BREAKING CHANGES
1. The '--scss' no longer has any effect
2. To enable SASS support via the command line,
   one must prefix their run-script command with
   ENABLE_SCSS=1 or ENABLE_SCSS=true.
Merge branch 'master' into master
b9b0e80
@mgechev
Copy link
Owner

mgechev commented Nov 8, 2016

Maybe we can keep both for backwards compatibility?

ENABLE_SCSS = ['true', '1'].indexOf(`${process.env.ENABLE_SCSS}`.toLowerCase()) !== -1 || argv['scss'] || false

@hankehly
Copy link
Contributor Author

hankehly commented Nov 9, 2016

@mgechev

Great idea. I've added back in the --scss flag.
It should be noted that use of the --scss flag with run-scripts including the AND operator could result in an error. I will update the necessary documentation with this information if this pull request is merged to master.

@mgechev mgechev merged commit 5d7e5db into mgechev:master Nov 9, 2016
mgechev added a commit that referenced this pull request Nov 9, 2016
@mgechev
Merge branch 'master' of https://github.com/mgechev/angular-seed
365f0ec 
* 'master' of https://github.com/mgechev/angular-seed:
  Specify ENABLE_SCSS setting via environment variable (#1603)
robstoll added a commit to robstoll/angular-seed that referenced this pull request Dec 4, 2016
@robstoll
Squashed last changes from mgechev/angular-seeed
ad2c33c 
# Conflicts:
#   README.md (using local)
#   appveyor.yml (using local)
#   yarn.lock (using seed)
#   tools/tasks/seed/build.js.e2e.ts (using seed)
#   tools/tasks/seed/tslint.ts (using seed)
#   tools/utils/seed/watch.ts (using seed)

commit 7a41979
Author: mgechev <[email protected]>
Date:   Wed Nov 30 17:01:24 2016 -0800

    chore: downgrade typescript

    Based on angular/angular#12966

commit 27568a5
Author: mgechev <[email protected]>
Date:   Tue Nov 29 10:40:19 2016 -0800

    docs: use proper command for running compodoc server

commit d3eb166
Merge: 111719e db1066c
Author: Minko Gechev <[email protected]>
Date:   Tue Nov 29 10:39:01 2016 -0800

    Merge pull request mgechev#1681 from mgechev/update-codelyzer

    chore: update to tslint 4 and codelyzer 2.0.0-beta.1

commit db1066c
Merge: 0c555c5 111719e
Author: mgechev <[email protected]>
Date:   Mon Nov 28 10:48:30 2016 -0800

    Merge master

commit 111719e
Merge: bec58c9 67d8fd2
Author: Minko Gechev <[email protected]>
Date:   Mon Nov 28 10:43:56 2016 -0800

    Merge pull request mgechev#1675 from mgechev/simplify-gulp

    feat(tasks): allow easier overriding of existing tasks

commit 0c555c5
Author: mgechev <[email protected]>
Date:   Sun Nov 27 17:42:28 2016 -0800

    chore: update to tslint 4 and codelyzer 2.0.0-beta.1

commit bec58c9
Merge: e93b2eb 76cecc0
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 27 15:26:58 2016 -0800

    Merge pull request mgechev#1680 from robstoll/env-property-example

    example for env-config usage in index.html

commit 76cecc0
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 27 21:45:58 2016 +0100

    example for env-config usage in index.html

commit 67d8fd2
Author: mgechev <[email protected]>
Date:   Sun Nov 27 10:02:22 2016 -0800

    docs: add missing file description

commit e93b2eb
Merge: b6d05b7 975d53d
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 27 10:00:00 2016 -0800

    Merge pull request mgechev#1677 from robstoll/cleanup-whitespace

    whitespace cleanup

commit b6d05b7
Merge: a199a12 db779bb
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 27 09:59:43 2016 -0800

    Merge pull request mgechev#1678 from robstoll/tslint-vscode

    chore: vscode tslint task fixed

commit db779bb
Merge: 3e64aaf a199a12
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 27 09:59:39 2016 -0800

    Merge branch 'master' into tslint-vscode

commit a199a12
Merge: d02b3f9 55348e7
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 27 09:56:39 2016 -0800

    Merge pull request mgechev#1679 from robstoll/template-locals

    refactor template_locals using builder

commit 55348e7
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 27 16:07:03 2016 +0100

    refactor template_locals using builder
    - the builder enables easier configuration without code duplication
    - removed the side effects of Object.assign by introducing new Objects
      (ENV_CONFIG was added to Config previsouly)
    - using a unstringified ENV_CONFIG to build index.html enables to refer to
      properties in index.html by <%= ENV_CONFIG.MY_PROPERTY %>

    # Conflicts:
    #	tools/tasks/seed/build.js.e2e.ts

commit 3e64aaf
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 27 15:21:45 2016 +0100

    problemMatcher pattern adopted to gulp-tslint
    - the rule name is no longer emitted by gulp-tslint and thus the pattern
      needs to be adopted in order that it still works

commit 48a8453
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 27 15:13:08 2016 +0100

    tslint did not print the full relative path

commit 975d53d
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 27 15:34:52 2016 +0100

    whitespace cleanup

commit 4493adc
Author: mgechev <[email protected]>
Date:   Sat Nov 26 11:24:47 2016 -0800

    feat(tasks): allow easier overriding of existing tasks

    Fix mgechev#1504

commit d02b3f9
Merge: 68691de 29ba295
Author: mgechev <[email protected]>
Date:   Sat Nov 26 10:54:54 2016 -0800

    Merge branch 'master' of https://github.com/mgechev/angular-seed

    * 'master' of https://github.com/mgechev/angular-seed:
      use v45
      Fixed tslint settings. Replaced some tabs to spaces.
      Fixed tslint settings. Replaced some tabs to spaces.

commit 68691de
Author: mgechev <[email protected]>
Date:   Sat Nov 26 10:54:47 2016 -0800

    chore: drop useless libs from tsconfig

commit 29ba295
Merge: 54ae158 f9894fe
Author: Minko Gechev <[email protected]>
Date:   Sat Nov 26 10:22:12 2016 -0800

    Merge pull request mgechev#1673 from StefanKoenen/tslint-indent-with-spaces

    Tslint indent with spaces

commit 54ae158
Merge: 7d0debd da184b2
Author: Minko Gechev <[email protected]>
Date:   Sat Nov 26 10:21:38 2016 -0800

    Merge pull request mgechev#1674 from Shyam-Chen/master

    use v45

commit da184b2
Author: 陳彥澄 <[email protected]>
Date:   Sat Nov 26 20:43:17 2016 +0800

    use v45

commit f9894fe
Merge: 5f9507a d5fffcd
Author: Stefan Koenen <[email protected]>
Date:   Sat Nov 26 12:24:15 2016 +0100

    Merged branch tslint-indent-with-spaces into tslint-indent-with-spaces

commit 5f9507a
Author: Stefan Koenen <[email protected]>
Date:   Wed Nov 23 21:30:46 2016 +0100

    Fixed tslint settings.
    Replaced some tabs to spaces.

commit 7d0debd
Merge: b7c7379 65f7cb3
Author: mgechev <[email protected]>
Date:   Thu Nov 24 11:32:41 2016 -0800

    Merge branch 'master' of https://github.com/mgechev/angular-seed

    * 'master' of https://github.com/mgechev/angular-seed:
      AOT compile fix for angular 2.2.3

commit b7c7379
Author: mgechev <[email protected]>
Date:   Thu Nov 24 11:32:27 2016 -0800

    fix(aot): set transitive properties

commit 65f7cb3
Merge: 9f12830 614a97c
Author: Minko Gechev <[email protected]>
Date:   Thu Nov 24 11:32:11 2016 -0800

    Merge pull request mgechev#1671 from karlhiramoto/aot-fix

    AOT compile fix for angular 2.2.3

commit 614a97c
Author: Karl Hiramoto <[email protected]>
Date:   Thu Nov 24 19:44:55 2016 +0100

    AOT compile fix for angular 2.2.3

commit d5fffcd
Author: Stefan Koenen <[email protected]>
Date:   Wed Nov 23 21:30:46 2016 +0100

    Fixed tslint settings.
    Replaced some tabs to spaces.

commit 9f12830
Author: mgechev <[email protected]>
Date:   Wed Nov 23 12:06:28 2016 -0800

    docs: drop mit badge

commit 14b0526
Merge: ea1a665 c11072f
Author: Minko Gechev <[email protected]>
Date:   Wed Nov 23 08:31:33 2016 -0800

    Merge pull request mgechev#1657 from Shyam-Chen/master

    remove yarn install on travis

commit ea1a665
Merge: 3633143 35f1ebe
Author: Minko Gechev <[email protected]>
Date:   Wed Nov 23 08:31:17 2016 -0800

    Merge pull request mgechev#1659 from hank-ehly/bugfix/AoT

    Fix failing AoT build

commit 35f1ebe
Author: Hank Ehly <[email protected]>
Date:   Wed Nov 23 17:57:38 2016 +0900

    Fix failing AoT build

    As of angular/angular b15039d, the 'transitiveModules' option has
    been removed from compiler-cli CodeGenerator's 'codegen' method.
    The current seed still includes this option, which causes the pr-
    oduction AoT build to fail. Removing the option -- just like has
    been done in the angular-cli source code -- fixes the production
    AoT build.

commit 3633143
Author: mgechev <[email protected]>
Date:   Wed Nov 23 00:23:32 2016 -0800

    docs: update the list of wiki contributors

commit c11072f
Author: 陳彥澄 <[email protected]>
Date:   Wed Nov 23 14:55:00 2016 +0800

    remove yarn install on travis

commit 5dc18eb
Merge: 006bb47 b39f580
Author: Minko Gechev <[email protected]>
Date:   Tue Nov 22 09:57:31 2016 -0800

    Merge pull request mgechev#1655 from miltador/miltador-fix-docker-prod

    Fix nginx template file name in docker-compose.production.yml

commit b39f580
Author: Vasiliy Solovey <[email protected]>
Date:   Tue Nov 22 14:46:01 2016 +0200

    Update docker-compose.production.yml

commit 006bb47
Merge: 2601d5e af8c9c9
Author: Minko Gechev <[email protected]>
Date:   Mon Nov 21 11:05:33 2016 -0800

    Merge pull request mgechev#1653 from robstoll/vscode-ignore-search

    chore: ignore generated code from vscode search

commit 2601d5e
Merge: 07f9850 8ddfdf7
Author: Minko Gechev <[email protected]>
Date:   Mon Nov 21 10:59:17 2016 -0800

    Merge pull request mgechev#1654 from robstoll/improve-env-error-message

    improve error message about unknown env name

commit 07f9850
Merge: 33f2dff e233029
Author: Minko Gechev <[email protected]>
Date:   Mon Nov 21 10:58:31 2016 -0800

    Merge pull request mgechev#1627 from robstoll/fix-routing

    routing corresponding to STYLE 02-12

commit 8ddfdf7
Author: Robert Stoll <[email protected]>
Date:   Mon Nov 21 19:41:03 2016 +0100

    improve error message about unknown env name

commit af8c9c9
Author: Robert Stoll <[email protected]>
Date:   Mon Nov 21 19:37:59 2016 +0100

    chore: ignore generated code from vscode search

commit e233029
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 13 23:29:08 2016 +0100

    routing corresponding to STYLE 02-12

commit 33f2dff
Merge: e78c461 c95e760
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 20 10:31:11 2016 -0800

    Merge pull request mgechev#1640 from brian428/feature/mgechev#1614

    Feature/mgechev#1614

commit e78c461
Merge: cdd2e92 f3ef0df
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 20 10:30:28 2016 -0800

    Merge pull request mgechev#1647 from mgechev/issue-1602

    feat(docker): provide docker nginx prod

commit f3ef0df
Author: TheDonDope <[email protected]>
Date:   Sun Nov 20 14:05:12 2016 +0100

    feat(docker): provide docker nginx prod

    Implement a docker production container, which serves the static files
    built from running `npm run build.prod` in a nginx web server.

    Fixes mgechev#1602

commit cdd2e92
Merge: d67674f 0cc2fb7
Author: Minko Gechev <[email protected]>
Date:   Sat Nov 19 15:20:01 2016 -0800

    Merge pull request mgechev#1646 from karlhaas/proxy-middleware

    Simplify proxy middleware configuration

commit d67674f
Merge: 82d4da1 5559cf7
Author: Minko Gechev <[email protected]>
Date:   Sat Nov 19 15:08:45 2016 -0800

    Merge pull request mgechev#1642 from VladimirMakaev/e2e-async-await

    Implement async/await for e2e tests

commit 0cc2fb7
Author: Karl Haas <[email protected]>
Date:   Sat Nov 19 23:59:54 2016 +0100

    Simplify proxy middleware configuration

commit c95e760
Merge: ea0ea2d 82d4da1
Author: Minko Gechev <[email protected]>
Date:   Fri Nov 18 14:57:58 2016 -0800

    Merge branch 'master' into feature/mgechev#1614

commit 5559cf7
Merge: 8ab8245 82d4da1
Author: Vladimir Makaev <[email protected]>
Date:   Fri Nov 18 21:32:37 2016 +0000

    Merge branch 'master' into e2e-async-await

commit 82d4da1
Merge: dc3d841 715b1ee
Author: Minko Gechev <[email protected]>
Date:   Fri Nov 18 12:22:34 2016 -0800

    Merge pull request mgechev#1644 from Marcelh29/patch-2

    missing tsc-wrapped error

commit 715b1ee
Author: Marcel Hoekstra <[email protected]>
Date:   Fri Nov 18 21:08:00 2016 +0100

    missing tsc-wrapped error

    depencency tsc-wrapped was removed

commit 8ab8245
Author: Vladimir Makayev <[email protected]>
Date:   Fri Nov 18 14:51:01 2016 +0000

    Implement async/await for e2e tests

commit ea0ea2d
Author: Brian Kotek <[email protected]>
Date:   Fri Nov 18 00:23:21 2016 -0500

    mgechev#1614 - Add clean.once to build.dev.js task to ensure that the build starts in a clean state.

commit 83ff9dd
Author: Brian Kotek <[email protected]>
Date:   Fri Nov 18 00:05:08 2016 -0500

    mgechev#1614 - Update codelyzer to prevent TemplateParser errors; update compodoc to latest.

commit fc62d7e
Author: Brian Kotek <[email protected]>
Date:   Fri Nov 18 00:04:23 2016 -0500

    mgechev#1614 - Remove tslint from build.test task.

commit 8a18a40
Author: Brian Kotek <[email protected]>
Date:   Fri Nov 18 00:02:53 2016 -0500

    mgechev#1614 - Update build.js.test.ts to use optional typeless compile interval, similar to what is used in build.js.dev.ts.

commit dc3d841
Merge: b5abf76 cfd2d47
Author: Minko Gechev <[email protected]>
Date:   Thu Nov 17 11:32:25 2016 -0800

    Merge pull request mgechev#1638 from netstart/devDependency

    Dev dependency

commit cfd2d47
Author: clayton.passos <[email protected]>
Date:   Thu Nov 17 17:11:55 2016 -0200

    fix

commit af3f02e
Author: Clayton K. N. Passos <[email protected]>
Date:   Thu Nov 17 11:12:12 2016 -0200

    add instructions to generate api documentation in readme

commit 5f0c0af
Author: Clayton K. N. Passos <[email protected]>
Date:   Thu Nov 17 11:09:25 2016 -0200

    move intl and minimath to dev dependency

commit b5abf76
Merge: 27be945 8b1cb96
Author: Minko Gechev <[email protected]>
Date:   Wed Nov 16 21:39:40 2016 -0800

    Merge pull request mgechev#1636 from jesperronn/remove_peer_dep_and_update_lockfile

    Removed @angular/tsc-wrapped as it is a peer dependency

commit 8b1cb96
Author: Jesper Rønn-Jensen <[email protected]>
Date:   Wed Nov 16 21:10:30 2016 +0100

    Removed @angular/tsc-wrapped as it is a peer dependency

    Also updated yarn lockfile, which was not done.

    According to tsc-wrapped page, it's an internal dependency

    > tsc-wrapped
    >
    > This package is an internal dependency used by @angular/compiler-cli. Please use that instead.

    See https://github.com/angular/angular/tree/master/tools/@angular/tsc-wrapped

commit 27be945
Merge: 6836784 c6cd77a
Author: mgechev <[email protected]>
Date:   Wed Nov 16 11:53:56 2016 -0800

    Merge branch 'master' of https://github.com/mgechev/angular-seed

    * 'master' of https://github.com/mgechev/angular-seed:
      - Fix resolution of external dependencies during production build on Linux

commit 6836784
Author: mgechev <[email protected]>
Date:   Wed Nov 16 11:53:51 2016 -0800

    refactor: drop hot reloader related comments

commit c6cd77a
Merge: a717b58 2a5ee44
Author: Minko Gechev <[email protected]>
Date:   Tue Nov 15 13:02:27 2016 -0800

    Merge pull request mgechev#1631 from ZuSe/master

    - Fix resolution of external dependencies during production build on Linux

commit a717b58
Author: mgechev <[email protected]>
Date:   Tue Nov 15 11:15:24 2016 -0800

    chore: update dependencies

commit 2a5ee44
Author: ppalacin <[email protected]>
Date:   Tue Nov 15 14:48:06 2016 +0100

    - Fix resolution of external dependencies during production build on Linux

commit 2f90871
Merge: 234a5fe c53fb8f
Author: Minko Gechev <[email protected]>
Date:   Mon Nov 14 15:48:43 2016 -0800

    Merge pull request mgechev#1624 from robstoll/vscode-tslint

    chore: add vscode task for tslint

commit c53fb8f
Merge: 832ff5a 234a5fe
Author: Minko Gechev <[email protected]>
Date:   Mon Nov 14 15:48:39 2016 -0800

    Merge branch 'master' into vscode-tslint

commit 234a5fe
Merge: 0551611 5c54822
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 13 15:07:55 2016 -0800

    Merge pull request mgechev#1628 from robstoll/cleanup

    a few cleanups

commit 5c54822
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 13 23:31:39 2016 +0100

    a few cleanups

commit 832ff5a
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 6 21:11:31 2016 +0100

    chore: add vscode task for tslint

commit 0551611
Merge: ce4d284 594a2b2
Author: Minko Gechev <[email protected]>
Date:   Fri Nov 11 08:41:13 2016 -0800

    Merge pull request mgechev#1623 from netstart/add-compodoc

    Add compodoc

commit 594a2b2
Author: Clayton K. N. Passos <[email protected]>
Date:   Fri Nov 11 11:53:41 2016 -0200

    remove documentation directori

commit bc96a64
Author: Clayton K. N. Passos <[email protected]>
Date:   Fri Nov 11 10:54:30 2016 -0200

    add compodoc to generate documentation like javadoc

commit b575f5e
Author: Clayton K. N. Passos <[email protected]>
Date:   Fri Nov 11 10:50:39 2016 -0200

    add compodoc to generate documentation like javadoc

commit ce4d284
Author: mgechev <[email protected]>
Date:   Thu Nov 10 12:32:11 2016 -0800

    fix(watch): wait 100ms before trigger build

    Close mgechev#1615

commit 6bd4c73
Author: mgechev <[email protected]>
Date:   Thu Nov 10 12:23:09 2016 -0800

    docs: update contributors list

commit 365f0ec
Merge: b3de2c8 5d7e5db
Author: mgechev <[email protected]>
Date:   Tue Nov 8 22:43:10 2016 -0800

    Merge branch 'master' of https://github.com/mgechev/angular-seed

    * 'master' of https://github.com/mgechev/angular-seed:
      Specify ENABLE_SCSS setting via environment variable (mgechev#1603)

commit b3de2c8
Author: mgechev <[email protected]>
Date:   Tue Nov 8 22:43:05 2016 -0800

    feat(config): set prod config in addPackageBundles

commit 5d7e5db
Author: Hank Ehly <[email protected]>
Date:   Wed Nov 9 11:19:22 2016 +0900

    Specify ENABLE_SCSS setting via environment variable (mgechev#1603)

    * Allow ENABLE_SCSS flag to be set via ENV variable

    Some npm run-scripts contain multiple gulp comman-
    ds (ex. e2e.ci). Multiple gulp commands may refer-
    ence the ENABLE_SCSS setting; however, '--scss' is
    only appended to the final command:

        gulp ... && gulp ... && gulp ... "--scss"

    This results in a build error.

    To provide each command in an npm run-script the
    correct ENABLE_SCSS setting, set the ENABLE_SCSS
    setting using an environment variable rather than
    a command-line argument.

    BREAKING CHANGES
    1. The '--scss' no longer has any effect
    2. To enable SASS support via the command line,
       one must prefix their run-script command with
       ENABLE_SCSS=1 or ENABLE_SCSS=true.

    * Keep '--scss' flag for backwards compatibility

commit 5010350
Author: mgechev <[email protected]>
Date:   Tue Nov 8 13:07:46 2016 -0800

    chore: update dependencies

commit 3f33d41
Author: ruffiem <[email protected]>
Date:   Mon Nov 7 19:23:08 2016 +0100

    (feat) reduced complexity when adding n additional packages (mgechev#1593)

    * (feat) reduced complexity when adding n additional packages

    * (feat) changed class instance property to local variable

    * (bug) fixed ExtendPackages interface implementation

    * (feat) commenting additional packages example

    * (bug) commenting ExtendPackages unused import

commit b5da527
Merge: e8f5cf3 b62ea79
Author: Minko Gechev <[email protected]>
Date:   Mon Nov 7 10:08:32 2016 -0800

    Merge pull request mgechev#1613 from netstart/add_minimatch

    add minimatch to run a specific tests

commit b62ea79
Author: Clayton K. N. Passos <[email protected]>
Date:   Mon Nov 7 10:22:05 2016 -0200

    add minimatch to run a specific tests

commit e8f5cf3
Merge: 6e985a9 c30b36d
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 6 13:55:49 2016 -0800

    Merge pull request mgechev#1610 from robstoll/vscode-using-ts-lib-in-node

    chore: using ts lib in node_modules for vscode

commit 6e985a9
Merge: 4b989f5 76cf0ad
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 6 13:53:57 2016 -0800

    Merge pull request mgechev#1608 from robstoll/update-yarn-lock

    chore: updated yarn.lock after install

commit c30b36d
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 6 21:31:50 2016 +0100

    chore: using ts lib in node_modules for vscode

commit 76cf0ad
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 6 21:27:20 2016 +0100

    updated yarn.lock after install

commit 4b989f5
Merge: 1d5e7ec 6944137
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 6 10:23:02 2016 -0800

    Merge pull request mgechev#1606 from robstoll/patch-1

    cache node_modules with dependency to package.json

commit 6944137
Merge: 15e5efd 1d5e7ec
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 6 10:22:56 2016 -0800

    Merge branch 'master' into patch-1

commit 1d5e7ec
Merge: 12825a1 2b28618
Author: Minko Gechev <[email protected]>
Date:   Sun Nov 6 10:17:22 2016 -0800

    Merge pull request mgechev#1596 from Nightapes/patch-2

    docs(README): add AoT section

commit 15e5efd
Author: Robert Stoll <[email protected]>
Date:   Sun Nov 6 18:10:42 2016 +0100

    cache node_modules with dependency to package.json

    I guess caching should be possible if it is invalidated in case package.json changes

commit 2b28618
Merge: ea60b0a 12825a1
Author: Sebastian <[email protected]>
Date:   Sun Nov 6 17:36:55 2016 +0100

    Merge branch 'master' into patch-2

commit ea60b0a
Author: Sebastian <[email protected]>
Date:   Sun Nov 6 13:36:06 2016 +0100

    docs(README): add AoT to table of contents

commit 75ebaa5
Author: Sebastian <[email protected]>
Date:   Sun Nov 6 13:35:09 2016 +0100

    docs(README): add AoT to table of contents

commit fc159d2
Author: Sebastian <[email protected]>
Date:   Fri Nov 4 14:04:55 2016 +0100

    docs(README): add AoT section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgechev mgechev mgechev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hankehly @mgechev