Move app_title and browser_list to project.config

[the-ult]

app_title and browser_list seem like project specific settings. Therefore, they should be defined in the project.config.ts instead of seed.config.ts

That way it is easier to overwrite seeds.config.ts every time there has been an update in angular2-seed.

Might even be an idea to create to following folders:

tools/
-- project
  -- config/
  -- tasks/
  -- utils/
-- seed
  -- config/
  -- tasks/
  -- utils/

That way you could easily update / clone angular2-seed again and just copy tools/seed to your project folder and you'll have all the fixes without having to compare it file to file.

[ludohenin]

Might even be an idea to create to following folders:

I tried this way when refactoring the tools and that's not ideal.
Anyway a utility will soon land to update from seed.

[joshwiens]

You can set APP_TITLE right here

[the-ult]

Aah.. ok..
Still in the mindset -> const can't be changed. .(JAVA) which isn't true in ES6.
(And somehow blind.. cause I did not see that line.. :-s -> need more sleep)

But, I still think the APP_TITLE in project.config.ts would be more logical. (instead of overriding).

[joshwiens]

IMO it is consistent with the conventions in the rest of the seed.

i.e. Project overrides Seed.

That said, given the confusion around const and the intent of immutability vs. the reality of the implementation I do agree that APP_TITLE conveys the idea that it can't be modified when in reality, it can be but technically we aren't.

const is kind of a mess, in particular if you come from something like Java or .Net

[the-ult]

Think you're correct with the consistency with the other conventions of the seed.

Other option could be a setter method for app_title which you can call from the project.config.ts constructor and other settings which are usually set in the project.config.ts but that sounds/feels messy as well.

What are the most overridden options besides APP_TITLE (and probably BROWSER_LIST)?

[joshwiens]

See #644

[mgechev]

@the-ult thanks for the contribution! Lets keep the title back in the seed config for now. It looks more consistent to me as well.

[the-ult]

No problem 😊

Op vr 18 mrt. 2016 11:12 schreef Minko Gechev [email protected]:

Closed #635 #635.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#635 (comment)

met vriendelijke groet,
Arjen

M 06-51 800 419
W www.payt.nl