Add initial code to support NPM plugin module configuration lookups; …

[brian428]

…add getPluginConfig() and mergeObject() methods to seed.config.ts; use getPluginConfig() for browser-sync and gulp-concat-css as an initial test. (#850)

[brian428]

Here's a start on the getPluginConfig() approach that we discussed over on #850. A few notes:

• To keep the imports elsewhere in the tasks simple and consistent, I just added getPluginConfig() to the SeedConfig class.
• I also added a mergeObject() helper method to SeedConfig to make it easy to add to or override the plugin configs (or any other objects in SeedConfig, really) from within ProjectConfig.
• As a start, I used getPluginConfig() for browser-sync and gulp-concat-css. If you think this approach is OK, other tasks can be updated to use this as well (even if, by default, no extra config is used).

Let me know what you think. Not sure if you want to merge this yet, but I figured I'd get it over to you to check out.

[TheDonDope]

Can be written as const deepExtend, since it is not reassigned afterwards.

[ludohenin]

I'm not big fan of require here. I'd prefer a definition file and import the module using the import syntax where needed. Don't you think so ?

[TheDonDope]

Hi @brian428,
i took a peek at your code and left some minor notes :)
Have a nice day!

[TheDonDope]

A parameter documentation would be nice :) like:

/**
 * Recursively merge source onto target.
 * @param {any} target <short description of target>
 * @param {any} source <short description of source>
 */

[ludohenin]

@brian428 any progress on this ?

[brian428]

Sorry...progress on what? Adding more uses of getPluginConfig()? Or making these small code style changes? I was basically waiting to hear whether the approach itself is OK.

[ludohenin]

I was basically waiting to hear whether the approach itself is OK.

Yes you're right, we forgot the essential.
LGTM :-)
You can go ahead.

[brian428]

I made the formatting and style changes as mentioned above. The only change I didn't tackle is the require() for deepExtend. Partly because the same syntax is used in numerous other spots across the tasks and configs. And partly because I'm not entirely sure what you mean about the "definition file and import" (I'm still coming to grips with the new module syntax myself).

[mgechev]

@brian428 LGTM!