(WIP) Implement application decoupling #959

TheDonDope · 2016-06-03T12:31:02Z

This PR continues #926, pushing the commits to this repositories own branch (issue/913-application-decoupling). It was rebased on the current master. Below is the original description including the last open tasks:

The PR is still a a work in progress:

Any feedback/help/change requests are welcome as always :)

Have a nice day!

Implements the application decoupling as discussed in #913.

Excludes karma.conf.js, protractor.conf.js and test-main.js from the copy build task, so that those files will not be copied over to /dist/** directory. Furthermore also excludes the tsconfig.json from this copy process, as it was copied over before too.

Updates the protractor configuration and associated gulp task.

Adds a e2e.singleRun gulp task to the gulpfile to leave the script in the package.json more compact. Also updates the README to include the new folder and file structure.

- Implements the application decoupling as discussed in #913. - Excludes karma.conf.js, protractor.conf.js and test-main.js from the copy build task, so that those files will not be copied over to /dist/** directory. Furthermore also excludes the tsconfig.json from this copy process, as it was copied over before too. - Updates the protractor configuration and associated gulp task. - Adds a e2e.singleRun gulp task to the gulpfile to leave the script in the package.json more compact. Also updates the README to include the new folder and file structure.

Updates the package.json and gulpfile.ts to fix the issue of running the e2e.singleRun task

Adds a separate package.json for the sources in src/browser.

TheDonDope · 2016-06-07T15:32:10Z

src/browser/package.json

@@ -0,0 +1,24 @@
+{
+  "name": "angular2-seed",


Do we need a new name here?

TheDonDope · 2016-06-07T15:36:28Z

Hey guys, i now added the separate package.json in src/browser but i am not quite sure what needs to be in there. If i understood correctly, the package.json in the root folder should only contain the dependencies necessary for the whole build chain, right? And therefore the src/browser/package.json should in turn include those dependencies for the angular2 client?

Looking for input and help here :)

// cc @mgechev @ludohenin @d3viant0ne @NathanWalker @Shyam-Chen

mgechev · 2016-06-07T15:56:35Z

package.json

@@ -13,8 +13,9 @@
    "build.test": "gulp build.test --color",
    "build.test.watch": "gulp build.test.watch --color",
    "generate.manifest": "gulp generate.manifest --color",
-    "e2e": "protractor",
-    "e2e.live": "protractor --elementExplorer",
+    "e2e": "protractor src/browser/protractor.conf.js",


The angular dependencies here should be dropped. Doesn't seem required.

Should we then also drop the whole "dependencies": { ... } section in the root package.json, since this has moved to the src/browser/package.json ?

NathanWalker · 2016-06-13T17:31:55Z

@TheDonDope Curious the latest status here? Do you currently need help or have questions at this point?

TheDonDope · 2016-06-13T19:08:58Z

Hey @NathanWalker,
i'm currently stuck on the refactor of the package.json. I'm not entirely clear on which packages need to be moved to the dedicated src/browser/package.jsonand how this affects the whole "scripts: { ...}" section of the root package.json. Furthermore, since the browser specific node modules will then live within the src/browser directory, we need to update the build tasks and configuration. To be honest i am a little overwhelmed by this and would be glad to get help on that. Basically, the todo list in the description of the PR is still valid:

implement dedicated package.json in src/browser

update build tasks / configuration to create dist/browser/dev|prod|test|tmp directories

Yet, though those 2 open tasks may sound straightforward, there is a bit more to it than it may sound.

The branch issue/913-application-decoupling is open for further commits :)

Thanks!

NathanWalker · 2016-06-13T19:21:11Z

Ok @TheDonDope thanks for update, I'll see if I can take a look at some point this week.

joshwiens · 2016-06-16T16:08:15Z

@TheDonDope - I'm picking up the last two tasks on the list. I'll PR the changes into the issue/913-application-decoupling branch

TheDonDope · 2016-06-16T16:35:37Z

@d3viant0ne Thank you very much!!!!!!!!

NathanWalker · 2016-06-17T06:31:06Z

@mgechev @TheDonDope --

@d3viant0ne and I are working on this together and plan to have a new PR ready here: https://github.com/DeviantJS/angular2-seed/pull/4 and complete for this by Friday night EST (at which time we will close this one in favor of the other), just fyi

mgechev · 2016-06-17T06:51:55Z

@NathanWalker sounds awesome! Thanks for the help! We're looking forward to merge your work!

NathanWalker · 2016-06-18T04:49:35Z

@mgechev Still working through the configuration, need to loosen completion estimate but hoping for this weekend.

TheDonDope · 2016-06-22T12:08:13Z

@d3viant0ne, @NathanWalker: Is there anything i can help you with? I saw there was a merge on your forks develop branch. Thank you so much for your work so far!! :)

Greetings

NathanWalker · 2016-06-23T08:39:49Z

@TheDonDope I must report that the decoupling presents problems with SystemJS. More than are likely worth it. We are experimenting in a private project at the moment.
@d3viant0ne You may invite him to the project where further discussions around the experimentations could take place.

joshwiens · 2016-06-23T17:43:02Z

I honestly just don't see a point in doing it. It's only going to serve to increase both complexity and fragility with at best, limited returns

TheDonDope · 2016-06-29T13:31:13Z

@NathanWalker @d3viant0ne
Hey guys, so do i understand it correctly, that the refactor is not feasible to do due to SystemJS issues? And in consequence the whole refactor is obsolete then?

joshwiens · 2016-06-29T15:36:18Z

@TheDonDope - I'm sure it's feasible but the implementation adds more complexity than it removes which kind of defeats the purpose.

mgechev · 2016-07-04T07:30:59Z

@d3viant0ne so after doing research you found out that the introduced complexity is not worth the decoupling that we're going to get?

What is the exact problem with SystemJS that prevents us from finishing the restructuring?

TheDonDope added 5 commits May 26, 2016 11:14

Implement application decoupling

c2e03ed

Implements the application decoupling as discussed in #913.

Update protractor configuration

4b2ca0b

Updates the protractor configuration and associated gulp task.

Add e2e.singleRun gulp task and update README

8ad5161

Adds a e2e.singleRun gulp task to the gulpfile to leave the script in the package.json more compact. Also updates the README to include the new folder and file structure.

TheDonDope mentioned this pull request Jun 3, 2016

(WIP) Implement application decoupling #926

Closed

10 tasks

TheDonDope changed the title ~~Issue/913 application decoupling~~ (WIP) Implement application decoupling Jun 3, 2016

TheDonDope added the work in progress label Jun 3, 2016

TheDonDope added 3 commits June 3, 2016 15:41

Update e2e.singleRun task

83de583

Updates the package.json and gulpfile.ts to fix the issue of running the e2e.singleRun task

Merge branch 'master' into issue/913-application-decoupling

78d6019

Add separate package.json

3d8ffb9

Adds a separate package.json for the sources in src/browser.

TheDonDope reviewed Jun 7, 2016
View reviewed changes

src/browser/package.json

@@ -0,0 +1,24 @@

{

"name": "angular2-seed",

Copy link

Contributor Author

TheDonDope Jun 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a new name here?

TheDonDope added the help wanted label Jun 7, 2016

mgechev reviewed Jun 7, 2016
View reviewed changes

NathanWalker mentioned this pull request Jun 7, 2016

HEADS UP: Refactor coming...Prepare. NathanWalker/angular-seed-advanced#119

Closed

mgechev mentioned this pull request Jun 15, 2016

Clean dev dependencies #985

Closed

joshwiens mentioned this pull request Jun 16, 2016

Upgrade Angular2-seed to rc.2 and new Routes NathanWalker/angular-seed-advanced#130

Closed

joshwiens assigned joshwiens and TheDonDope Jun 16, 2016

joshwiens removed the help wanted label Jun 16, 2016

joshwiens mentioned this pull request Jun 16, 2016

feature(appDecouple): Dedicated Application Dependencies #1003

Closed

8 tasks

joshwiens mentioned this pull request Jun 16, 2016

feature(appDecouple): Platforms Implementation #1004

Closed

8 tasks

TheDonDope mentioned this pull request Jun 19, 2016

[WIP] chore(devDeps): Update dev dependencies #1015

Closed

jvitor83 mentioned this pull request Jun 24, 2016

Generator for this Seed-Advanced (Proposal) NathanWalker/angular-seed-advanced#137

Closed

mgechev closed this Jul 15, 2016

TheDonDope mentioned this pull request Jul 29, 2016

Application decoupling #913

Closed

TheDonDope deleted the issue/913-application-decoupling branch September 1, 2016 19:41

(WIP) Implement application decoupling #959

(WIP) Implement application decoupling #959

Uh oh!

Conversation

TheDonDope commented Jun 3, 2016

Uh oh!

TheDonDope Jun 7, 2016

Choose a reason for hiding this comment

Uh oh!

TheDonDope commented Jun 7, 2016

Uh oh!

mgechev Jun 7, 2016

Choose a reason for hiding this comment

Uh oh!

TheDonDope Jun 7, 2016

Choose a reason for hiding this comment

Uh oh!

mgechev Jun 7, 2016

Choose a reason for hiding this comment

Uh oh!

NathanWalker commented Jun 13, 2016

Uh oh!

TheDonDope commented Jun 13, 2016 • edited by mgechev Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NathanWalker commented Jun 13, 2016

Uh oh!

joshwiens commented Jun 16, 2016

Uh oh!

TheDonDope commented Jun 16, 2016

Uh oh!

NathanWalker commented Jun 17, 2016 • edited by joshwiens Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mgechev commented Jun 17, 2016

Uh oh!

NathanWalker commented Jun 18, 2016

Uh oh!

TheDonDope commented Jun 22, 2016

Uh oh!

NathanWalker commented Jun 23, 2016

Uh oh!

joshwiens commented Jun 23, 2016

Uh oh!

TheDonDope commented Jun 29, 2016

Uh oh!

joshwiens commented Jun 29, 2016

Uh oh!

mgechev commented Jul 4, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TheDonDope commented Jun 13, 2016 •

edited by mgechev

Loading

NathanWalker commented Jun 17, 2016 •

edited by joshwiens

Loading

mgechev commented Jul 4, 2016 •

edited

Loading