Pywin32 - Release 226 breaks Virtualenv.

[KelSolaar]

Note that issues in this repository are only for bugs or feature requests in the pywin32.

If you need support or help using this package, please follow these instructions - support or help requests will be closed without comment.

For all bugs, please provide the following information.

• Expected behavior and actual behavior.

Pip installation of packages in virtual environments after having installed Pywin32 should work.

• Steps to reproduce the problem.

I'm not exactly sure what is happening but it seems like Pywin32 - Release 226 overrides the site.py module to a degree: https://github.com/colour-science/colour/runs/296273919#step:6:71

2019-11-10T09:31:49.6665830Z   - Installing pywin32 (226)
2019-11-10T09:31:55.9900265Z   - Installing traitlets (4.3.3)
2019-11-10T09:31:56.0385213Z 
2019-11-10T09:31:56.0385876Z [EnvCommandError]
2019-11-10T09:31:56.0386325Z Command ['C:\\Users\\runneradmin\\AppData\\Local\\pypoetry\\Cache\\virtualenvs\\colour-9UyTvm6t-py2.7\\Scripts\\python.exe', '-m', 'pip', 'install', '--no-deps', 'traitlets==4.3.3'] errored with the following return code 1, and output: 
2019-11-10T09:31:56.0386682Z Traceback (most recent call last):
2019-11-10T09:31:56.0386831Z 
2019-11-10T09:31:56.0390404Z   File "C:\Users\runneradmin\AppData\Local\pypoetry\Cache\virtualenvs\colour-9UyTvm6t-py2.7\lib\site.py", line 769, in <module>
2019-11-10T09:31:56.0391101Z 
2019-11-10T09:31:56.0391696Z     main()
2019-11-10T09:31:56.0391836Z 
2019-11-10T09:31:56.0392174Z   File "C:\Users\runneradmin\AppData\Local\pypoetry\Cache\virtualenvs\colour-9UyTvm6t-py2.7\lib\site.py", line 746, in main
2019-11-10T09:31:56.0392414Z 
2019-11-10T09:31:56.0392683Z     paths_in_sys = addsitepackages(paths_in_sys)
2019-11-10T09:31:56.0392841Z 
2019-11-10T09:31:56.0393147Z   File "C:\Users\runneradmin\AppData\Local\pypoetry\Cache\virtualenvs\colour-9UyTvm6t-py2.7\lib\site.py", line 279, in addsitepackages
2019-11-10T09:31:56.0393361Z 
2019-11-10T09:31:56.0393635Z     addsitedir(sitedir, known_paths)
2019-11-10T09:31:56.0393778Z 
2019-11-10T09:31:56.0394067Z   File "C:\Users\runneradmin\AppData\Local\pypoetry\Cache\virtualenvs\colour-9UyTvm6t-py2.7\lib\site.py", line 202, in addsitedir
2019-11-10T09:31:56.0394280Z 
2019-11-10T09:31:56.0394499Z     addpackage(sitedir, name, known_paths)
2019-11-10T09:31:56.0394700Z 
2019-11-10T09:31:56.0394997Z   File "C:\Users\runneradmin\AppData\Local\pypoetry\Cache\virtualenvs\colour-9UyTvm6t-py2.7\lib\site.py", line 170, in addpackage
2019-11-10T09:31:56.0395160Z 
2019-11-10T09:31:56.0395377Z     exec(line)
2019-11-10T09:31:56.0395557Z 
2019-11-10T09:31:56.0395843Z   File "<string>", line 1, in <module>
2019-11-10T09:31:56.0395993Z 
2019-11-10T09:31:56.0396291Z   File "C:\Users\runneradmin\AppData\Local\pypoetry\Cache\virtualenvs\colour-9UyTvm6t-py2.7\lib\site-packages\win32\lib\pywin32_bootstrap.py", line 14, in <module>
2019-11-10T09:31:56.0396511Z 
2019-11-10T09:31:56.0397903Z     for maybe in site.getsitepackages():
2019-11-10T09:31:56.0398374Z 
2019-11-10T09:31:56.0399692Z AttributeError: 'module' object has no attribute 'getsitepackages'

Pretty much same build with Release 225 was fine yesterday: https://github.com/colour-science/colour/commit/b8399d28760179f46f7090dd69457565d1754403/checks?check_suite_id=303070722#step:6:42

• Version of Python and pywin32

Python 2.7 and Pywin32 - Release 226

Cheers,

Thomas

[vashek]

This is because of pypa/virtualenv#228 (and it break pipenv as a consequence, too).
This is the commit in pywin32 that caused it: 71afa71#diff-1fbc440d4725e98acddc7667ffb63fe6

[CMTaylor]

I'm having this issue, too. Going back to 225 is a workaround for now.