[Feature Request] Option to terminate Service and trigger recovery actions

[LincolnPuzey]

I am using the win32serviceutil.ServiceFramework class to write a Windows Service.

I have a use-case where I would like my service to terminate in such a way that the recovery actions (e.g. restart service) are triggered.

By default these recovery actions are triggered when the service terminates without reporting a status of SERVICE_STOPPED.

I have tried overriding svcRun and raising an exception or calling sys.exit(), eg

def SvcRun(self):
    self.ReportServiceStatus(win32service.SERVICE_RUNNING)

    # ideally this would cause the service process to end without any further calls to SetServiceStatus(),
    # so the recovery actions are triggered.
    raise Exception()

but pywin32 sets the service status to SERVICE_STOPPED in its cleanup actions after calling SvcRun.
https://github.com/mhammond/pywin32/blob/master/win32/src/PythonService.cpp#L907

Ideally there would be some way for SvcRun to flag that this cleanup should not be done.

My current workaround is to call os.kill(os.getpid(), signal.SIGABRT), which avoids the cleanup. But I would like to avoid such a nuclear option.

[mhammond]

It's probably reasonable that we only report SERVICE_STOPPED if there's no exception raised from running the entry-point.

[LincolnPuzey]

For a better workaround, is there anything I can do to effect the sshStatusHandle value so that the first if here

if (pe && pe->sshStatusHandle) {  // Wont be true if debugging.
    if (!SetServiceStatus(pe->sshStatusHandle, &stoppedStatus))
        ReportAPIError(PYS_E_API_CANT_SET_STOPPED);
}

is False and the status isn't set?

[mhammond]

Nope - but your workaround sounds fine and reasonable.

[LincolnPuzey]

Ok yeah I'm getting my head around the c++. I though maybe sshStatusHandle might be something on my service class.

[LincolnPuzey]

Your suggested fix sounds good to me.

[LincolnPuzey]

For the record my workaround now is to call os._exit(0) when I want the service to terminate.