Skip to content

Add PRINTER_INFO_6 support in Set/GetPrinter#1853

Merged
mhammond merged 5 commits intomhammond:mainfrom
CristiFati:cfati_dev00
Apr 14, 2022
Merged

Add PRINTER_INFO_6 support in Set/GetPrinter#1853
mhammond merged 5 commits intomhammond:mainfrom
CristiFati:cfati_dev00

Conversation

@CristiFati
Copy link
Copy Markdown
Contributor

According to [MS.Docs]: GetPrinter function, PRINTER_INFO_6 (and thus level 6), is a valid choice.

Note: there's not much extra real value, as the status is also included in PRINTER_INFO_2.

Copy link
Copy Markdown
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be great to add a short note to CHANGES.txt giving yourself credit!

Comment thread win32/src/win32print/win32print.cpp
@CristiFati CristiFati requested a review from mhammond April 13, 2022 03:52
Copy link
Copy Markdown
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! 👍

@mhammond mhammond merged commit 5052346 into mhammond:main Apr 14, 2022
@CristiFati CristiFati deleted the cfati_dev00 branch May 14, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants