Skip to content

Overhaul and vastly simplify service registration process.#1908

Merged
mhammond merged 1 commit intomainfrom
service-registration
Jul 25, 2022
Merged

Overhaul and vastly simplify service registration process.#1908
mhammond merged 1 commit intomainfrom
service-registration

Conversation

@mhammond
Copy link
Copy Markdown
Owner

@mhammond mhammond commented Jul 3, 2022

No description provided.

@mhammond mhammond force-pushed the service-registration branch from 39b2311 to 6975a79 Compare July 3, 2022 06:35
@mhammond
Copy link
Copy Markdown
Owner Author

mhammond commented Jul 3, 2022

After things like #1795, #1811, #1871 and #1840, I decided that really the service registration code was plain broken and lots of old 20 year cruft that confused the issue, and that complicated warning just made things worse. So I just removed most of that and tried to keep it simple - if pythonservice.exe isn't in a good place,at service registration time we just move it to sys.exec_prefix and use it from there.

It works for me in a vanilla pypi install of pywin32, even without the post-install script having been run, but it should work even when it has and even when installed via a .exe

@Fnordbert, @Wissperwind, @MedvedevSA, @lucasg you've all been burnt by this in the issues above, so if any of you have time, I'd love some feedback about whether it works for you. Artifacts can be found by selecting the "actions" tab for the project, finding the most recent runs for this PR, then selecting "artifacts" (it's a bit hidden, let me know if you need help finding them).

@mhammond mhammond force-pushed the service-registration branch from 6975a79 to fcab714 Compare July 24, 2022 23:57
@mhammond mhammond merged commit 97ec1b4 into main Jul 25, 2022
@mhammond mhammond deleted the service-registration branch July 25, 2022 01:00
@Fnordbert
Copy link
Copy Markdown
Contributor

Sorry for the slow response. I will have a closer look next time I get to work on my service. (which could still be a while)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants