Make modal dialog the default again in combrowse.main()#1924
Merged
mhammond merged 2 commits intomhammond:mainfrom Aug 13, 2022
Merged
Make modal dialog the default again in combrowse.main()#1924mhammond merged 2 commits intomhammond:mainfrom
mhammond merged 2 commits intomhammond:mainfrom
Conversation
.. after d10d559 (non-modal COM browser inside PythonWin IDE). combrowse.py may be run / called from outside PythonWin as a standalone GUI in a console (mhammond#1895). Run the browser modeless when called from PythonWin tool menu or when run as script inside PythonWin GUI. Fix similar startup of tlbrowse.py: win32api.GetConsoleTitle() meanwhile returns empty string when no console.
* freeze setuptools<=63.2.0 for now: XXX With setuptools 63.4.3 .. 64.0.0 the scintilla nmake run won't compile. (setuptools.msvc._msvc14_get_vc_env() won't get the VC\INCLUDE into os.environ.) Let's see if this will be fixed again in higher versions of setuptools. * print the cl.exe full path and environ INCLUDE during _build_scintilla() / nmake for future tracking * use and fixup scintilla.mak instead of scintilla_vc6.mak (which is outdated lacks some dependencies)
mhammond
reviewed
Aug 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.. and 2nd patch: make scintilla build again on github CI (by freezing
setuptoolsversion so far - the recent update github broke the INCLUDE & LIB paths for the scintilla nmake run, in github at least)