Add CascadeWindows wrapper#1999
Conversation
|
Most likely, tests failed because machine is down. |
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
Thanks - I think we need that null check - and do you mind adding something to CHANGES.txt?
| if (PyTuple_Check(childrenObject)) { | ||
| childCount = (UINT)(PyTuple_GET_SIZE(childrenObject)); | ||
| if (childCount) { | ||
| children = (HWND*)(malloc(sizeof(HWND) * childCount)); |
| DWORD gle = GetLastError(); | ||
| if (gle) { | ||
| PyWin_SetAPIError("CascadeWindows", gle); | ||
| return NULL; |
There was a problem hiding this comment.
I assume it is intentional that zero will be returned if GetLastError() returns zero, rather than an exception? (The docs on the api function aren't really that clear) - but maybe a comment makes sense?
|
Hi @mhammond: Not related to this PR, but I couldn't find a better channel to ask. There's [PyPI]: pypiwin32. I know that (at this point) it's old and outdated, but was it ever useful for someone / something? To me it looks just like a playground, the "universal" variant seems to just have this as a dependency. If it doesn't bring any value, is there a chance it could be removed? |
|
It existed before pywin32 itself supported being packaged as a wheel. I don't think it has much current value, but presumably there are still things out there that depend on it? TBH, I can't even recall who created it as I guess that's who we should ask (but know it wasn't me!) |
2 participants
Wrap [MS.Learn]: CascadeWindows function (winuser.h).