adodbapi: Remove references to outdated IronPython

[Avasam]

Split off from #1990 to make it easier to review in isolation.

Remove obsoleted IronPython code and references to IronPython, which does not support any recent enough python version.

[mhammond]

@vernondcole WDYT?

[vernondcole]

This work is great! -- I have been meaning to do something like this for years, but, since I work mostly on Linux these days, have not gotten around to it. It needs to be a bit more aggressive than you have been in pulling old stuff. I am adding comments as I review. Most importantly, though, this will alter enough things that it should have a complete test before it is merged. I will spin up three VMs to test against, and that will take a bit of time. The CI test does not do significant testing of this module.

…

On Mon, Apr 24, 2023 at 12:24 PM Avasam ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In adodbapi/adodbapi.py <#2049 (comment)>: > @@ -24,7 +24,6 @@ DB-API 2.0 specification: http://www.python.org/dev/peps/pep-0249/ This module source should run correctly in CPython versions 2.7 and later, I'm trying to keep specifically CPython2 code cleanup to its own PR (#1990 <#1990>), and splitting things up in smaller bites. Otherwise I end up with a ton of changes if I remove/update python2 specific code (ie, that PR), and when something break (see failing test) it's harder to find which change did it. Comments like these also help find said obsolete code. That said, this comment doesn't point to specific Python2 code, so if you want me to update it in this here PR, I can do that. (but at least wanted to explain why I didn't remove it in the first place) — Reply to this email directly, view it on GitHub <#2049 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAEZOBP6ZHPIIL7EIAMDAZTXC3AOTANCNFSM6AAAAAAXGJVJPY> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Avasam]

@vernondcole I believe all comments have been addressed

[mhammond]

oops, I mistook one of the commits for the entire PR - this still needs Vernon's review.

[Avasam]

Thanks for the review!
(pinging @mhammond now that this has been approved)