Change mbcs encoding to utf-8 in com/win32com/client#2097
Merged
mhammond merged 4 commits intomhammond:mainfrom Nov 1, 2023
Merged
Change mbcs encoding to utf-8 in com/win32com/client#2097mhammond merged 4 commits intomhammond:mainfrom
mbcs encoding to utf-8 in com/win32com/client#2097mhammond merged 4 commits intomhammond:mainfrom
Conversation
Avasam
commented
Aug 9, 2023
mhammond
requested changes
Aug 10, 2023
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
I think for now we should only change the COM functions - where we generate a .py file. Most of the other places changed are quite possibly wrong as it's not Python file IO consuming the bytes.
Avasam
changed the title
mbcs encoding to utf-8mbcs encoding to utf-8 in com/win32com/client
Collaborator
Author
Bumping this PR. This has been approved but not merged @mhammond |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1990 (comment)
- @mhammond
This changes more than what the initial comment mentioned, but I figured may as well review all usages of it. Even if we end up reverting because the needed changes would be too big or wrong.mbcstoutf-8incom/win32com/clientmbcsencoding code inPythonwin/pywin/