adodbapi: Remove outdated and unused remote feature#2098
Merged
Avasam merged 6 commits intomhammond:mainfrom Apr 10, 2024
Merged
adodbapi: Remove outdated and unused remote feature#2098Avasam merged 6 commits intomhammond:mainfrom
Avasam merged 6 commits intomhammond:mainfrom
Conversation
Avasam
changed the title
Avasam
changed the title
…e-adodbapi-remote-feature
…e-adodbapi-remote-feature
vernondcole
requested changes
Mar 28, 2024
Collaborator
vernondcole
left a comment
vernondcole
left a comment
There was a problem hiding this comment.
I don't understand what is going on here, but I don't think that changes to 147 files is what you had in mind. I think that this PR is in error.
Collaborator
Author
@vernondcole There's only 10 files changed. 3 of which are removal, and 1 is documentation. Are you confusing this with a different PR ? |
vernondcole
approved these changes
Mar 28, 2024
Collaborator
vernondcole
left a comment
vernondcole
left a comment
There was a problem hiding this comment.
Looks good.
Perhaps github showed me the wrong expansion for this? What I see now is not what I saw before.
…e-adodbapi-remote-feature
…e-adodbapi-remote-feature
…e-adodbapi-remote-feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See conversation in #2094
- @vernondcole
This PR removes the
adodbapi.remotefeature entirely, and properly cleans up all references to it. As well as now unused code and redundant conditions.