Cleanup `win32comext.axdebug` by Avasam · Pull Request #2126 · mhammond/pywin32

Avasam · 2023-09-22T00:12:24Z

This is the combination of the following changes, but scoped specifically to the win32comext.axdebug module:

Fix: flake8 "undefined name" errors #1994
Fix undefined names reported by Flake8/Ruff #2101
Basic type-checking with mypy and pyright #2102
Prefer f-strings and non-printf-style format #2122 (+ manual changes)
Update Python2 string module usage #2127
Update Python2 print commands left in comments and docs #2128
+ comments spacing
then ran format_all.bat

Merging this first will reduce changes everywhere else.
Non-obvious changes are clarified in comments.

Avasam · 2023-09-22T00:14:27Z

-def TestSmartHelper():
-    pdm = pythoncom.CoCreateInstance(
-        axdebug.CLSID_ProcessDebugManager,
-        None,
-        pythoncom.CLSCTX_ALL,
-        axdebug.IID_IProcessDebugManager,
-    )
-    app = pdm.CreateApplication()
-    app.SetName("Python Process")
-
-    pydebugger = adb.Debugger()
-
-    nodes = BuildModuleTree()
-
-    all_real_nodes = CreateDebugDocumentHelperNodes(pdm, app, nodes)
-    root = app.GetRootNode()
-    AttachParentNodes(root, nodes, all_real_nodes)
-
-    pydebugger.AttachApp(app)
-    cookie = pdm.AddApplication(app)
-    input("Waiting...")
-    ttest.test()
-
-    pdm.RemoveApplication(cookie)
-    print("Done")
-
-
-def testdumb():
-    pdm = pythoncom.CoCreateInstance(
-        axdebug.CLSID_ProcessDebugManager,
-        None,
-        pythoncom.CLSCTX_ALL,
-        axdebug.IID_IProcessDebugManager,
-    )
-    app = pdm.GetDefaultApplication()
-
-    nodes = BuildModuleTree()
-    all_real_nodes = CreateDebugDocumentHelperNodes(pdm, app, nodes)
-    AttachParentNodes(None, nodes, all_real_nodes)
-
-    parentNode = None
-    all_real_nodes = {}
-    input("Waiting...")
-    print("Done")
-
-


These were commented out in the caller code (so it's unused) and contain a bunch of undefined names / unbound variables that I can't find anywhere.
If you still think it's worth keeping around, I'll comment them out instead.

Avasam · 2023-09-22T00:16:08Z

-from win32com.axdebug import axdebug
+from win32com.axdebug import axdebug, contexts
+from win32com.axdebug.util import _wrap
 from win32com.server.exception import Exception

-from . import contexts
-from .util import RaiseNotImpl, _wrap
-


PS E:\Users\Avasam\Documents\Git\pywin32\com\win32comext\axdebug> python codecontainer.py Traceback (most recent call last): File "E:\Users\Avasam\Documents\Git\pywin32\com\win32comext\axdebug\codecontainer.py", line 19, in <module> from . import contexts ImportError: attempted relative import with no known parent package

Avasam · 2023-09-22T00:17:18Z

-    sys.path.append(".")
-    import ttest
+    from Test import ttest


I tested running this script from both pywin32\com\win32comext\axdebug and pywin32\com\win32comext\axdebug\Test. With this change, it finds the module in both cases.

Avasam · 2023-09-22T00:27:47Z



-class DebugDocumentText(gateways.DebugDocumentInfo, gateways.DebugDocumentText):
+class DebugDocumentText(gateways.DebugDocumentText):


MRO issue, #2071 did not do enough

>>> import win32comext.axdebug.documents Traceback (most recent call last): File "<stdin>", line 1, in <module> File "C:\Program Files\Python39\lib\site-packages\win32comext\axdebug\documents.py", line 37, in <module> class DebugDocumentText( TypeError: Cannot create a consistent method resolution order (MRO) for bases DebugDocumentInfo, DebugDocumentText

Avasam · 2023-09-22T00:30:13Z

-    from win32com.server.util import unwrap
-
-    print("Wrapped items:")
-    for key, items in all_wrapped.items():


Nothing ever modifies all_wrapped. Meaning this code likely does nothing.

…up-axdebug

mhammond

Thanks!