Remove deprecated win32com.server.exception.Exception#2142
Merged
mhammond merged 2 commits intomhammond:mainfrom Mar 14, 2024
Merged
Conversation
Avasam
changed the title
win32com.server.exception.Exception
Avasam
force-pushed
the
remove-deprecated-win32com.server.exception.Exception
branch
from
35a21e1 to
dc80dd5
Compare
Avasam
force-pushed
the
remove-deprecated-win32com.server.exception.Exception
branch
from
dc80dd5 to
1340303
Compare
…e-deprecated-win32com.server.exception.Exception
Owner
I'd be super surprised if it is used anywhere, given that the point of using axscript.server would be for other languages to invoke Python code and those other languages really aren't going to have access to this anyway. |
Avasam
deleted the
remove-deprecated-win32com.server.exception.Exception
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Something I came across. This really ought to be removed to avoid shadowing builtin
ExceptionNote that this can impact users, so it is a "breaking change". Not that it's a hard one to update (change 1 aliased name
Exception->COMException). So it should at least be communicated in a changelog.Figured with all the recent refactoring it might be a good time.
Not sure what to do with
com.win32comext.axscript.server.error.Exception. As far as I can tell, it's unused in pywin32's code, but could maybe be used in downstream code for better com object traceback? I could rename it to avoid the builtin shadowing, but it wasn't previously marked as deprecated/obsolete.