Improve DispatcherWin32dbg's deprecation warning and raised error#2145
Merged
Avasam merged 3 commits intomhammond:mainfrom Mar 14, 2024
Merged
Improve DispatcherWin32dbg's deprecation warning and raised error#2145Avasam merged 3 commits intomhammond:mainfrom
DispatcherWin32dbg's deprecation warning and raised error#2145Avasam merged 3 commits intomhammond:mainfrom
Conversation
mhammond
requested changes
Mar 14, 2024
Owner
mhammond
left a comment
There was a problem hiding this comment.
Feel free to merge after changing that text, thanks!
|
|
||
| DispatcherWin32dbg_deprecation_message = """\ | ||
| The DispatcherWin32dbg dispatcher is deprecated! | ||
| Please let me know if this is a problem. |
Owner
There was a problem hiding this comment.
while we are touching this, maybe change this line to, eg, "please open an issue at https://github.com/mhammond/pywin32/ is this is a problem"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This used to raise without even printing the warning!
I could've moved the print statements up, but instead I've improved the error by raising a
DeprecationWarningwith the message:Note that if you want to send an actual warning, we should use the warning module. But this used to raise an error already. It's just clearer now.
Alternatively we could just remove this class entirely if you did not get any report of users needing it.