MakeGW improvements#2180
Merged
mhammond merged 4 commits intomhammond:mainfrom Feb 20, 2024
Merged
Conversation
Merged
mhammond
approved these changes
Feb 20, 2024
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
This seems fine, thanks! I don't think this has generated code which compiled without modification for well over a decade!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is just side work as I was trying to add IFolderView functionality (to properly answer to [SO]: How to move desktop icons with python?) to win32comext.shell, and the process is annoying (well, since the 2nd time I was running it from command line via -c, but having proper argument handling is the way to go).
As I was saying I was trying to add IFolderView, but the file no longer parses modern headers (tried ShObjIdl_core.h), due to __RPC__* specifiers (from rpcsal.h). It generates the files, but they don't compile due to (wrongly interpreting argument types - at least this is what I've seen so far).
I have some more changes (not included here) to the same file (basically getting rid of those specifiers), but the output files still need manual intervention (didn't reach (yet) a point where the file compiles (and works)).
Given the headache involved, I'm thinking I'm on the wrong path as there were no (significant) changes on the file file for a long long time, could it be a simpler variant?
As I also mentioned there, this is a side quest for #2181.
Last 2 commits made my life much easier, but there's still some work to be done, so that it works in an automated manner.