Remove IE version checks and fix testExplorer.TestObjectFromWindow#2229
Merged
Avasam merged 1 commit intomhammond:mainfrom Apr 11, 2024
Merged
Remove IE version checks and fix testExplorer.TestObjectFromWindow#2229Avasam merged 1 commit intomhammond:mainfrom
testExplorer.TestObjectFromWindow#2229Avasam merged 1 commit intomhammond:mainfrom
Conversation
mhammond
approved these changes
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IE10 is out of support since January 14, 2020 https://learn.microsoft.com/en-us/lifecycle/announcements/internet-explorer-10-end-of-support
The only versions of IE available nowadays should be 11, and the code wasn't checking for any version higher than 7 already.
I also fixed the
testExplorer.TestObjectFromWindowtest since it was referencing IE8. the test now passes with flying (or flashing 😉) colors!