Skip to content

CredGetSessionTypes support#2232

Merged
mhammond merged 2 commits intomhammond:mainfrom
CristiFati:cfati_dev00
Mar 28, 2024
Merged

CredGetSessionTypes support#2232
mhammond merged 2 commits intomhammond:mainfrom
CristiFati:cfati_dev00

Conversation

@CristiFati
Copy link
Copy Markdown
Contributor

@CristiFati CristiFati commented Mar 28, 2024

Fixes #2067.

I noticed across the module that GIL is not released during native API calls. Is there a specific reason for that?

Copy link
Copy Markdown
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no good reason the GIL is not release elsewhere.

@mhammond mhammond merged commit 484eeda into mhammond:main Mar 28, 2024
@Avasam
Copy link
Copy Markdown
Collaborator

Avasam commented Mar 28, 2024

@CristiFati consider using closing keywords before the issue number when linking to the fixed issue ! So they can be better tracked and not accidentally left open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CredGetSessionTypes is not implemented in win32credmodule.cpp

3 participants