Using augmented assignements (in-place operators) where possible#2274
Merged
Avasam merged 6 commits intomhammond:mainfrom Jun 4, 2024
Merged
Using augmented assignements (in-place operators) where possible#2274Avasam merged 6 commits intomhammond:mainfrom
Avasam merged 6 commits intomhammond:mainfrom
Conversation
mhammond
approved these changes
Jun 4, 2024
clin1234
pushed a commit
to clin1234/pywin32
that referenced
this pull request
Jun 7, 2024
Avasam
added a commit
to Avasam/pywin32
that referenced
this pull request
Dec 31, 2024
Avasam
added a commit
that referenced
this pull request
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most were found thanks to https://docs.astral.sh/ruff/rules/non-augmented-assignment/
Then, since Ruff/PLR6104 doesn't support associative operations (yet astral-sh/ruff#11656), I used the following regex to find more:
(\w+?) = (\(\n\s+)\1 ([\+\-\*/\|&%~]|>>|<<|\*\*|//)-->$1 $3= ((\w+?) = \1 ([\+\-\*/\|&%~]|>>|<<|\*\*|//)-->$1 $2=(\w+?) = f('|")\{\1\}-->$1 += f$2Then manually reviewed the whole thing.