Type EventSink.myInvokeMethod as non-None in normal circumstance + re-enable reportOptionalCall#2285
Open
Avasam wants to merge 7 commits intomhammond:mainfrom
Open
Type EventSink.myInvokeMethod as non-None in normal circumstance + re-enable reportOptionalCall#2285Avasam wants to merge 7 commits intomhammond:mainfrom
EventSink.myInvokeMethod as non-None in normal circumstance + re-enable reportOptionalCall#2285Avasam wants to merge 7 commits intomhammond:mainfrom
Conversation
Avasam
changed the title
reportOptionalCall
Avasam
changed the title
reportOptionalCallEventSink.myInvokeMethod as non-None in normal circumstance + re-enable reportOptionalCall
…ht-reportOptionalCall
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Letting Editors and checkers know that
self.myInvokeMethod = Noneshouldn't mean thatmyInvokeMethodcould be None in normal circumstances (a closedEventSinkshouldn't be used anymore).Although maybe there's a better way of releasing resources? (like
del, or assigning a default method that throws an error indicating that the object is already closed)