Fix ddeclient and ddeserver demos import error#2290
Merged
Avasam merged 5 commits intomhammond:mainfrom Oct 26, 2024
Merged
Conversation
Avasam
force-pushed
the
ddeserver-demo-import-error
branch
from
ca6e78b to
887ead8
Compare
Avasam
force-pushed
the
ddeserver-demo-import-error
branch
from
887ead8 to
d9159a8
Compare
mhammond
approved these changes
Oct 26, 2024
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
not sure this is worth a changelog entry tbh
Collaborator
Author
My thought process is: Demos are public-facing. And it's a fix for an issue that was raised, so it visibly affects at least a user. It's probably similar to fixing documentation. I'll keep it since you're not requesting to remove the entry. But it's always up to you if you decide to remove it later. (note that there's already mentions of fixing demos in previous changelog entries) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1258