Remove cgi | Fix isapi.ThreadPoolExtension's printing of exception traceback#2312
Merged
mhammond merged 1 commit intomhammond:mainfrom Oct 4, 2024
Merged
Remove cgi | Fix isapi.ThreadPoolExtension's printing of exception traceback#2312mhammond merged 1 commit intomhammond:mainfrom
cgi | Fix isapi.ThreadPoolExtension's printing of exception traceback#2312mhammond merged 1 commit intomhammond:mainfrom
Conversation
…ken on Python 3.8+
elupus
approved these changes
Oct 2, 2024
elupus
left a comment
elupus
left a comment
There was a problem hiding this comment.
Looks good to me, but i have no commit rights here.
mhammond
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cgi.escapeis deprecated since Python 3.2 and removed in Python 3.8 https://docs.python.org/3.7/library/cgi.html#cgi.escapeThe entire
cgimodule is removed in Python 3.13: https://peps.python.org/pep-0594/#deprecated-modulesThis would be caught by mypy with
attr-definedturned back on, or by pyright withreportAttributeAccessIssueback on.