Fix Python failure handling in Pythonwin/pywin/framework/scriptutils.py

CHANGES.md

@@ -18,6 +18,7 @@ As of build 305, installation .exe files have been deprecated; see
 Coming in build 312, as yet unreleased
 --------------------------------------
 
+* Fixed Python failure handling in Pythonwin and improve error message (mhammond#2319, [@Avasam][Avasam])
 * Fixed `axdebug` build on Python 3.11+ using CPython's new opaque frame APIs, fixed 64-bit overflow in sourceContext and stack addresses, fixed incorrect step-over and step-out behavior, and fixed `ListEnumeratorGateway.Next()` returning lazy `map` iterator incompatible with C++ COM gateways that require a sequence (mhammond#2723, mhammond#2724, mhammond#2725, [@wxinix-2022][wxinix-2022])
 * Removed more leftover obsolete `UNICODE` constants since dropping Python 2 support in `win32ui`, `win32gui` and `win32clipboard` (mhammond#2717, [@Avasam][Avasam])
 * Implement COM Records as `[out]` method parameters (mhammond#2708, [@geppi][geppi], [@the-snork][the-snork])

pythonwin/pywin/framework/scriptutils.py

@@ -2,6 +2,8 @@
 Various utilities for running/importing a script
 """
 
+from __future__ import annotations
+
 import bdb
 import linecache
 import os
@@ -547,14 +549,13 @@ def RunTabNanny(filename):
     data = newout.getvalue()
     if data:
         try:
-            lineno = data.split()[1]
-            lineno = int(lineno)
+            lineno = int(data.split()[1])
             _JumpToPosition(filename, lineno)
             try:  # Try and display whitespace
                 GetActiveEditControl().SCISetViewWS(1)
             except:
                 pass
-            win32ui.SetStatusText("The TabNanny found trouble at line %d" % lineno)
+            win32ui.SetStatusText(f"The TabNanny found trouble at line {lineno}")
         except (IndexError, TypeError, ValueError):
             print("The tab nanny complained, but I can't see where!")
             print(data)
@@ -602,21 +603,19 @@ def JumpToDocument(fileName, lineno=0, col=1, nChars=0, bScrollToTop=0):
     return view
 
 
-def _HandlePythonFailure(what, syntaxErrorPathName=None):
-    typ, details, tb = sys.exc_info()
+def _HandlePythonFailure(what: str, syntaxErrorPathName: str | None = None) -> None:
+    details = sys.exc_info()[1]
     if isinstance(details, SyntaxError):
+        filename = details.filename
+        if (not filename or filename == "<string>") and syntaxErrorPathName:
+            filename = syntaxErrorPathName
         try:
-            msg, (fileName, line, col, text) = details
-            if (not fileName or fileName == "<string>") and syntaxErrorPathName:
-                fileName = syntaxErrorPathName
-            _JumpToPosition(fileName, line, col)
+            _JumpToPosition(filename, details.lineno, details.offset)
         except (TypeError, ValueError):
-            msg = str(details)
-        win32ui.SetStatusText(f"Failed to {what} - syntax error - {msg}")
+            pass
     else:
         traceback.print_exc()
-        win32ui.SetStatusText(f"Failed to {what} - {details}")
-    tb = None  # Clean up a cycle.
+    win32ui.SetStatusText(f"Failed to {what} - {type(details)} - {details}")
 
 
 # Find the Python TabNanny in either the standard library or the Python Tools/Scripts directory.