Skip to content

Fixed unbound globals in Pythonwin/pywin/dialogs/ideoptions.py #2325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Avasam wants to merge 1 commit into from
Closed

Fixed unbound globals in Pythonwin/pywin/dialogs/ideoptions.py #2325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ https://mhammond.github.io/pywin32_installers.html.
Coming in build 308, as yet unreleased
--------------------------------------

* Fixed unbound globals in `Pythonwin/pywin/dialogs/ideoptions.py` (#2325, @Avasam)

Build 307, released 2024-10-04
------------------------------
### Release process changes
Expand Down
10 changes: 8 additions & 2 deletions Pythonwin/pywin/dialogs/ideoptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@
win32ui.IDC_BUTTON3: win32ui.IDC_EDIT3,
}

formatTitle = interact.formatTitle
formatInput = interact.formatInput
formatOutput = interact.formatOutput
formatOutputError = interact.formatOutputError


class OptionsPropPage(dialog.PropertyPage):
def __init__(self):
Expand Down Expand Up @@ -111,8 +116,9 @@ def ChangeFormat(self, fmtAttribute, fmt):
return None
return dlg.GetCharFormat()

def OnFormatTitle(self, command, code):
fmt = self.GetFormat(interact.formatTitle)
def OnFormatTitle(self, command, code) -> None:
global formatTitle
fmt = self.GetFormat(formatTitle)
if fmt:
formatTitle = fmt
interact.SaveFontPreferences()
Expand Down