mypy annotations quick wins (resolve many str-format, has-type, valid-type, var-annotated, valid-type, type-var)#2336
Open
Avasam wants to merge 9 commits intomhammond:mainfrom
Open
mypy annotations quick wins (resolve many str-format, has-type, valid-type, var-annotated, valid-type, type-var)#2336Avasam wants to merge 9 commits intomhammond:mainfrom
Avasam wants to merge 9 commits intomhammond:mainfrom
Conversation
Avasam
commented
Nov 26, 2025
Comment on lines
+442
to
443
| if hasattr(mod, "__file__") and mod.__file__: | ||
| fname = mod.__file__ |
Collaborator
Author
There was a problem hiding this comment.
Alternatively
Suggested change
| if hasattr(mod, "__file__") and mod.__file__: | |
| fname = mod.__file__ | |
| if fname := getattr(mod, "__file__", None): |
Avasam
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I simply turned on
check_untyped_defs = trueand resolved as many str-format, has-type, valid-type, var-annotated, valid-type and type-var as I could.Some are left to other PRs:
Pythonwin/pywin/framework/scriptutils.py#2319Overlaps with #2321, #2333, and #2397, merging those first would reduce changes here