Skip to content

Enable flake8-type-checking (TCH) to prevent regressions due to extra imports for type-checking purposes #2388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avasam merged 3 commits into from
Oct 13, 2024
+7 −1
Merged

Enable flake8-type-checking (TCH) to prevent regressions due to extra imports for type-checking purposes #2388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
79f4742
Enable flake8-type-checking (TCH) to prevent regressions due to extra…
Avasam Oct 7, 2024
c2ae9c9
Discard changes to .github/workflows/main.yml
Avasam Oct 11, 2024
c3c722d
Merge branch 'main' into flake8-type-checking
Avasam Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion com/win32comext/axscript/client/error.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
from win32com.server.exception import COMException

if TYPE_CHECKING:
# Prevent circular imports
from win32comext.axscript.client.debug import DebugManager
from win32comext.axscript.client.framework import AXScriptCodeBlock, COMScript
from win32comext.axscript.server.axsite import AXSite
Expand Down
7 changes: 7 additions & 0 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ select = [
"UP007", # non-pep604-annotation
"UP010", # unnecessary-future-import
"UP037", # quoted-annotation

# Helps prevent circular imports and other unneeded imports
"TCH", # flake8-type-checking
]
extend-ignore = [
# No such concerns for stdlib
"TCH003", # typing-only-standard-library-import
]

[lint.per-file-ignores]
Expand Down