Conversation
Collaborator
|
The black failure is fixed either by bumping the min Python version to 3.9 for that CI job (like this https://github.com/mhammond/pywin32/pull/2207/files#diff-7829468e86c1cc5d5133195b5cb48e1ff6c75e3e9203777f6b2e379d9e4882b3R113-R115), pinning black to 24.8 instead of stable (I already pin other checkers anyway for that exact reason), or switching to Ruff format (#2389) I'm working on adding a quick test for the postinstall script for sanity test, if you'd like that to be in first. (not 100% sure where it should go, but that can be discussed in the PR) #2392 |
mhammond
force-pushed
the
push-nzulumzsunlv
branch
from
051a545 to
73050ed
Compare
mhammond
force-pushed
the
push-nzulumzsunlv
branch
from
73050ed to
2c2dc0b
Compare
Owner
Author
|
I think this is all we need for a new release - WDYT? |
Avasam
approved these changes
Oct 12, 2024
Collaborator
Avasam
left a comment
Avasam
left a comment
There was a problem hiding this comment.
Yeah looks like all the important recent bugfixes 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.