Removed considerations for Windows 95/98/ME#2400
Merged
Avasam merged 15 commits intomhammond:mainfrom Sep 27, 2025
Merged
Conversation
Avasam
force-pushed
the
Remove-Windows-95-98-ME
branch
from
c06e77c to
2935175
Compare
Avasam
commented
Oct 13, 2024
Avasam
commented
Oct 13, 2024
Avasam
commented
Oct 13, 2024
Avasam
commented
Oct 13, 2024
Avasam
commented
Oct 13, 2024
Comment on lines
+107
to
+109
| // On platforms that don't have NT security, | ||
| // the initialization of the SECURITY_DESCRIPTOR should fail, | ||
| // leaving the sd NULL. |
Collaborator
Author
Owner
There was a problem hiding this comment.
I don't see much value in doing that tbh.
mhammond
reviewed
Mar 4, 2025
mhammond
approved these changes
Jul 22, 2025
Comment on lines
+107
to
+109
| // On platforms that don't have NT security, | ||
| // the initialization of the SECURITY_DESCRIPTOR should fail, | ||
| // leaving the sd NULL. |
Owner
There was a problem hiding this comment.
I don't see much value in doing that tbh.
Collaborator
Author
|
Thanks, I'll probably go through your last set of reviews over the week. |
Collaborator
Author
|
Only changed a comment as requested since last review. Will merge after (if) tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review this carefully, I'm a bit out of my depth in certain places and am left guessing. I've left GitHub comments on specific files.