Fix for issue #2415: Python 3.12.7 interpreter crashes#2417
Merged
mhammond merged 1 commit intomhammond:mainfrom Dec 12, 2024
Merged
Fix for issue #2415: Python 3.12.7 interpreter crashes#2417mhammond merged 1 commit intomhammond:mainfrom
mhammond merged 1 commit intomhammond:mainfrom
Conversation
when accessing a COM Record field.
Collaborator
Author
|
A humble question: Will this PR make it into the next release and is there a schedule for this? Currently COM Records do not work with Python 3.12 and the pywin32 release available on PyPi. |
mhammond
approved these changes
Dec 12, 2024
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
Sorry for the delay, this looks good! I'm not sure when the next release will be yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when accessing a COM Record field.
It looks like the culprit is calling
PyWinObject_FreeWCHAR()while not holding the GIL.The fix is moving the call to
PyWinObject_FreeWCHAR()outside of thePY_INTERFACE_PRECALL/PY_INTERFACE_POSTCALLblock to reacquire the GIL before the call.This pull request resolves issue #2415