PythonService DoLogMessage raising fatal GIL lock error. #2426
Merged
mhammond merged 2 commits intomhammond:mainfrom Nov 14, 2024
Merged
PythonService DoLogMessage raising fatal GIL lock error. #2426mhammond merged 2 commits intomhammond:mainfrom
mhammond merged 2 commits intomhammond:mainfrom
Conversation
…g of variable out of Py Allow Threads block
mhammond
reviewed
Nov 13, 2024
Owner
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
Thanks! Do you mind adding a CHANGELOG entry for this?
Collaborator
|
I just did a pass looking at all |
Contributor
Author
Hey Mark, no worries. I've updated the changelog.txt, is this fine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening pull request for potential fix to #2155. @guentner suggested moving freeing of msg object in LogErrorMsg call out of PyBeginAllowThreads block.
On Python 3.12 services were crashing from a call to servicemanager.LogErrorMsg().
Found error occurred when tested on 3.12.2 and 3.12.7
By commenting out all calls to LogErrorMsg() the service crashes were fixed.
@guentner found this was being raised here PythonService.cpp
I've used the artifact build for Python3.12 and this has resolved my issue.