Skip to content

Added support for relative path for the -destination argument #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avasam merged 5 commits into from
Mar 8, 2025
+7 −3
Merged

Added support for relative path for the -destination argument #2454

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
313eacc
Added support for relative path for the `-destination` argument
Avasam Jan 8, 2025
1dae6ae
Add PR number
Avasam Jan 8, 2025
9dc3a3c
Merge branch 'main' into pywin32_postinstall-relative-path-support
Avasam Mar 4, 2025
469fc79
Merge branch 'main' of https://github.com/mhammond/pywin32 into pywin…
Avasam Mar 4, 2025
1640496
Merge branch 'main' of https://github.com/mhammond/pywin32 into pywin…
Avasam Mar 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ https://mhammond.github.io/pywin32_installers.html .
Coming in build 309, as yet unreleased
--------------------------------------

* Added support for relative path for `pywin32_postinstall`'s `-destination` argument (#2454, @Avasam)
* Changed the implementation of 'com_record' to a subclassable Python type (2437#, #2361, @geppi)
* Removed param `hIcon` from `win32comext.shell.ShellExecuteEx`. It was unusable since Windows Vista (#2423, @Avasam)
* Fixed `nbios.NCBStruct` packing (#2406, @Avasam)
Expand Down
7 changes: 5 additions & 2 deletions pywin32_postinstall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,9 +642,12 @@ def uninstall(lib_dir):
# Out of principle, we're still not using system exits.


def verify_destination(location):
def verify_destination(location: str) -> str:
location = os.path.abspath(location)
if not os.path.isdir(location):
raise argparse.ArgumentTypeError(f'Path "{location}" does not exist!')
raise argparse.ArgumentTypeError(
f'Path "{location}" is not an existing directory!'
)
return location


Expand Down