Make PackMENUITEMINFO: please use dwItemData instead of dwTypeData an actual DeprecationWarning#2595
Merged
Avasam merged 3 commits intomhammond:mainfrom Jun 17, 2025
Conversation
Avasam
changed the title
PackMENUITEMINFO: please use dwItemData instead of dwTypeData an actual DeprecationWarning
Avasam
force-pushed
the
Make-PackMENUITEMINFO--please-use-dwItemData-instead-of-dwTypeData-an-actual-DeprecationWarning
branch
from
3bd3e4f to
1e3ca4e
Compare
… actual DeprecationWarning
Avasam
force-pushed
the
Make-PackMENUITEMINFO--please-use-dwItemData-instead-of-dwTypeData-an-actual-DeprecationWarning
branch
from
1e3ca4e to
eb4ee66
Compare
mhammond
approved these changes
Jun 16, 2025
…-instead-of-dwTypeData-an-actual-DeprecationWarning
Avasam
deleted the
Make-PackMENUITEMINFO--please-use-dwItemData-instead-of-dwTypeData-an-actual-DeprecationWarning
branch
Collaborator
Author
|
And back under 70 PRs ! Thanks a lot for the steady PR reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment mentions wanting to "nuke" this waaaaay in the past. And it does warn users. But just like for #2503, it wasn't an actual
DeprecationWarning.Also set
stacklevel=2to help point to faulty caller code (see #2594 to help remember setting the stacklevel)