Bugfix for COM Record instance creation.#2641
Merged
mhammond merged 2 commits intomhammond:mainfrom Aug 27, 2025
Merged
Conversation
When a tuple of com_record instances was created from a SAFEARRAY of COM Records, the data of all com_record tuple elements was always stored in the RecordBuffer segment of the first com_record tuple element.
Collaborator
Author
|
Something seems to be broken with the CI workflow: |
Collaborator
Author
|
It is very important to merge this before the next release, please. Ooops. |
mhammond
approved these changes
Aug 27, 2025
Owner
mhammond
left a comment
There was a problem hiding this comment.
thanks! It would be great to get a test in a later PR if possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a serious bug in the code that creates a new COM Record instance.
It kicks in when a tuple of com_record instances is created from a SAFEARRAY of COM Records.
The bug causes the data of all com_record tuple elements to be stored in the same RecordBuffer segment, i.e. the segment dedicated to the first com_record tuple element.
I'm sorry, this was my mistake in the implementation of PR #2437 and will be fixed by this PR.