Skip to content

5m CI speedup per Test job: Stop manually installing VS Components #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avasam merged 2 commits into from
Feb 11, 2026
Merged

5m CI speedup per Test job: Stop manually installing VS Components #2692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
faa9ae4
Stop manually installing VS Components
Avasam Dec 10, 2025
ba0ae10
Merge branch 'main' of https://github.com/mhammond/pywin32 into stop-…
Avasam Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/install-vs-components.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# See https://github.com/actions/runner-images/issues/9701
# Adapted from https://github.com/actions/runner-images/issues/9873#issuecomment-2139288682

# NOTE: This isn't currently needed, but script is kept in case Microsoft breaks GitHub-hosted runners for us again

import os
import platform
from itertools import chain
Expand Down
11 changes: 4 additions & 7 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
test:
name: Build and test
runs-on: ${{ matrix.os }}
timeout-minutes: 30
timeout-minutes: &timeout-minutes 25
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -72,9 +72,6 @@ jobs:
- name: Add msbuild to PATH
uses: microsoft/setup-msbuild@v2

- name: Install missing Visual Studio components
run: python .github\workflows\install-vs-components.py

- name: Build and register the PyCOMTest server dll
# Pass Silent flag to regsvr32 to avoid hanging on confirmation window
run: com/TestSources/PyCOMTest/buildAndRegister.bat /s
Expand All @@ -99,7 +96,7 @@ jobs:
cross_compile_arm64:
name: Cross-compile ARM64
runs-on: windows-2022
timeout-minutes: 30
timeout-minutes: *timeout-minutes
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -143,7 +140,7 @@ jobs:
# This job can be run locally by running `pre-commit run`
checkers:
runs-on: ubuntu-latest
timeout-minutes: 30
timeout-minutes: *timeout-minutes
steps:
- uses: actions/checkout@v4
- uses: astral-sh/setup-uv@v7
Expand Down Expand Up @@ -177,7 +174,7 @@ jobs:

type-checkers:
runs-on: ubuntu-latest
timeout-minutes: 30
timeout-minutes: *timeout-minutes
strategy:
fail-fast: false
matrix:
Expand Down
Loading