clang-format: Use MacroBlock for Py_*_ALLOW_THREADS formatting#2733
Open
Avasam wants to merge 2 commits intomhammond:mainfrom
Open
clang-format: Use MacroBlock for Py_*_ALLOW_THREADS formatting#2733Avasam wants to merge 2 commits intomhammond:mainfrom
MacroBlock for Py_*_ALLOW_THREADS formatting#2733Avasam wants to merge 2 commits intomhammond:mainfrom
Conversation
e3de5d5 to
c8f58b2
Compare
MacroBlock for Py_*_ALLOW_THREADS formatting
Owner
|
If we are touching (almost) every |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not squash merge, to preserve the commit hash in .git-blame-ignore-revs
The first commit is applied formatting using the second commit's configs, and is 100% automated by just running clang-format.
Alternatively there's also
Macroshttps://clang.llvm.org/docs/ClangFormatStyleOptions.html#macros which gets clang-format to try and expand specific macros, but that makes the formatter non-portable (I ran this PR on my Linux machine, andMacrosmakes clang-format crash because I don't havellvm-symbolizeron my PATH)I prefer doing this over adding
;everywhere because then clang-format will also correctly increase indentation inside the macro block. Adding visual clarity that it is, indeed, a block.Py_*_ALLOW_THREADSis standard to Python, so I don't feel like this is "special-casing" the formatter configs to pywin32.PY_INTERFACE_PRECALL/PY_INTERFACE_POSTCALL,GUI_BGN_SAVE/GUI_END_SAVEandPyW32_BEGIN_ALLOW_THREADS/PyW32_END_ALLOW_THREADS(which are all the same thing), differ in that they're not block-scoped.