Rename Pythonwin folder to pythonwin, matching the final module name#2738
Conversation
e883452 to
86d7334
Compare
86d7334 to
5955fa4
Compare
|
I'm slightly reluctant here as some vcs are likely to get upset. |
If you have concerns about path move/file rename + content change confusing git: That's why I'm keeping those in 2 different commits. worst case scenario, a contributor can re-clone the repo if they're having a very weird edge case they can't fix. (something like they unknowingly configured their git to care about folder casing, but the rename isn't being applied on checkout, not sure if an actual issue, just a hypothetical) |
|
I personally hit this regularly in repos that rename files on disk. Splitting it across commits has never helped me. It is a mild inconvenience and rarely requires a full re-clone, although on the other side of the coin:
What's the worst case scenario of not taking this? |
You mean not taking this PR? The alternative is I have to change some code strings from Not against doing it, but I did want to first offer what I felt was the more "correct" change. |
mhammond
left a comment
There was a problem hiding this comment.
yeah, this is better I agree. And my issue is really because I use jj instead of git, which doesn't handle that well. So yeah, ok :)
|
Oh interesting, and looking at their tracker I found a related issue... that you happen to already have commented on ! jj-vcs/jj#1737 |
Do not squash merge !
This PR is intended to be in multiple commits. There's content changes in only 15 files.
git mv Pythonwin pythonwin.git-blame-ignore-revsand doing the actual manual content changesThis is a follow-up to #2735 . But instead of updating lower-case
pythonwinto match the current folder, I madePythonwinin-source folder lower-case.The reasoning is that this now matches 1-to-1 the source to the published wheel and module name
import pythonwin.This changes nothing for regular Windows native builds. Still fixes path issues for case-sensitive systems, and makes it easier to not have to think "Is this referencing the source folder
Pythonwinor the distributed folderpythonwin"