Fix scripts in bin/ #53
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the rv-sim and rv-jit scripts on bin/ use relative paths and will break if called from outside the rv8 code folder. This commit makes them calculate absolute paths and use them instead of the relative ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the scripts are not passing the arguments to rv-jit and rv-sim, so using the programs in any meaningful way without installing it is not possible. Additionally, the use of relative paths for linking means the scripts only work when ran on the rv8 directory. The included patches add "$@" so that the arguments get to the programs, and replaces relative paths with absolute ones.